-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds script to run notebooks and catch any errors #2616
Conversation
The notebooks parameterize the output_dir to manage files output by the notebook Moves behavior_ophys_session notebook to internal since it can only be run internally Adds github actions to run the notebook runner
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jobs: | ||
run_notebooks: | ||
name: Notebook runner | ||
runs-on: "ubuntu-latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of python would this use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default version of python that ships with the "ubuntu-latest" image, which currently is 3.8, but looks like it will be 3.10 on december 1:
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md
doc_template/examples_root/examples/nb/visual_behavior_neuropixels_data_access.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was interesting to see how notebooks can be parameterized and automated with papermill.
@mikejhuang thanks for feedback. I think I addressed all your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What if the output of the notebook changes without throwing errors? Is there a way to review it?
@mikejhuang the notebook changes are automatically committed, like in this commit . But we can review the auto commit. |
#2601
papermill
(library used to run notebooks) docs. Before, these paths referenced internal paths or fake paths, and so the notebook wouldn't run.