Add disable are descendants loaded property #16813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jja725
approved these changes
Jan 23, 2023
LuQQiu
approved these changes
Jan 24, 2023
|
alluxio-bot, merge this please |
jja725
pushed a commit
to jja725/alluxio
that referenced
this pull request
Jan 27, 2023
### What changes are proposed in this pull request? This adds a property to the list status call to disable the are descendants loaded check. ### Why are the changes needed? Currently before a recursive listing happens, the entire enclosed set of files are traversed to see if they all have the descendants loaded flag set in order to check if a metadata sync is needed. This can be costly especially if doing batch or partial listings. By setting this property the check can be avoided. This is, for example, recommended to set to true on the calls following the first call of a batch listing. Note that this is recommended as more of a temporary fix for internal libraries, until a new logic design for the metadata sync is completed. ### Does this PR introduce any user facing changes? New property in the list status options proto. pr-link: Alluxio#16813 change-id: cid-bd1fdbc4be0cadd9dda1a4115043db4b6a89c6a5
jja725
pushed a commit
to jja725/alluxio
that referenced
this pull request
Mar 11, 2023
This adds a property to the list status call to disable the are descendants loaded check. Currently before a recursive listing happens, the entire enclosed set of files are traversed to see if they all have the descendants loaded flag set in order to check if a metadata sync is needed. This can be costly especially if doing batch or partial listings. By setting this property the check can be avoided. This is, for example, recommended to set to true on the calls following the first call of a batch listing. Note that this is recommended as more of a temporary fix for internal libraries, until a new logic design for the metadata sync is completed. New property in the list status options proto. pr-link: Alluxio#16813 change-id: cid-bd1fdbc4be0cadd9dda1a4115043db4b6a89c6a5
alluxio-bot
added a commit
that referenced
this pull request
May 16, 2023
### What changes are proposed in this pull request? This PR cherry picks missing changes from `master-2.x` in the latter half of 2023/01, namely 2023/01/16~2023/01/31. The missing commits can be found at main...master-2.x Two PRs were left out because they have been manually cherry-picked to the dora/main branch: #16813 #16122 pr-link: #17432 change-id: cid-4c33092ccaae3302eb0f944183aa81ac08df226b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This adds a property to the list status call to disable the are descendants loaded check.
Why are the changes needed?
Currently before a recursive listing happens, the entire enclosed set of files are traversed to see if they all have the descendants loaded flag set in order to check if a metadata sync is needed. This can be costly especially if doing batch or partial listings. By setting this property the check can be avoided. This is, for example, recommended to set to true on the calls following the first call of a batch listing.
Note that this is recommended as more of a temporary fix for internal libraries, until a new logic design for the metadata sync is completed.
Does this PR introduce any user facing changes?
New property in the list status options proto.