Refactor collectMetrics command #17111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ssz1997
commented
Mar 17, 2023
ssz1997
commented
- We added more information to the response JSON string. Make the whole thing a JSON string for easier parsing.
- Refactor the get metrics part for reusing.
jiacheliu3
approved these changes
Mar 20, 2023
| @@ -122,62 +158,46 @@ private void masterMetrics(StringWriter outputBuffer, int i) throws IOException | |||
| // Do not break the loop since the HTTP failure can be due to many reasons | |||
| // Return the error message instead | |||
| LOG.error("Failed to get Alluxio master metrics from URL {}. Exception: ", url, e); | |||
| metricsResponse = String.format("Url: %s%nError: %s", url, e.getMessage()); | |||
| metricsResponse = String.format("{Url: \"%s\",%n\"Error\": %s}", url, e.getMessage()); | |||
There was a problem hiding this comment.
im fine with this manual wrapping for now. An alternative is to wrap it with an object like
class CollectMetricsResponse {
String url;
String error;
String body;
}
Then use jackson ObjectMapper to convert to json. Up to you :)
|
collectMetrics.txt |
|
alluxio-bot, merge this please |
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 17, 2023
1. We added more information to the response JSON string. Make the whole thing a JSON string for easier parsing. 2. Refactor the get metrics part for reusing. pr-link: Alluxio#17111 change-id: cid-0675889969cfe77f069f84c2eb02ae1aa55a0b0b
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 18, 2023
1. We added more information to the response JSON string. Make the whole thing a JSON string for easier parsing. 2. Refactor the get metrics part for reusing. pr-link: Alluxio#17111 change-id: cid-0675889969cfe77f069f84c2eb02ae1aa55a0b0b
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 19, 2023
1. We added more information to the response JSON string. Make the whole thing a JSON string for easier parsing. 2. Refactor the get metrics part for reusing. pr-link: Alluxio#17111 change-id: cid-0675889969cfe77f069f84c2eb02ae1aa55a0b0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.