[DOCFIX] Update the style of nav list #17760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenorith
reviewed
Jul 11, 2023
docs/_includes/sitemap.html
Outdated
Comment on lines
4
to
10
| {% for files in item.subfiles %} | ||
| <div> | ||
| <button class = "single"> | ||
| <a class = "single-items" href="{{site.baseurl}}{{ files.url }}" >{{ item.title }}</a> | ||
| </button> | ||
| </div> | ||
| {% endfor %} |
There was a problem hiding this comment.
if only 1 subfile, then no need for loop?
Xenorith
reviewed
Jul 11, 2023
docs/_includes/sitemap.html
Outdated
| {% if item.subfiles.size == 1 %} | ||
| <div> | ||
| <button class = "single"> | ||
| <a class = "single-items" href="{{site.baseurl}}{{ files.url }}" >{{ item.title }}</a> |
There was a problem hiding this comment.
does files.url still work without the files variable that was in the for loop?
also shift identation
Xenorith
approved these changes
Jul 11, 2023
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make a differentiation between a title w/ subfiles vs a title with a single file. if it's only a single file, then create the button link instead of the dropdown style. This pr is related change based on #17737
example without format:
with format:
