-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ALLUXIO-1825] Pooling open ByteBufferKeyValuePartitionReader in KeyValueWorkerClientServiceHandler #3140
Conversation
Hi @TeddyBear1314, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Merged build finished. Test PASSed. |
Test PASSed. |
You did it @TeddyBear1314! Thank you for signing the Contribution License Agreement. |
* A pool to store ByteBufferKeyValuePartitionReader, BlockReader and the associated lockId.This | ||
* pool has a fixed size and uses the access order to evict when the pool is full. | ||
*/ | ||
public class ByteBufferKeyValuePartitionReaderPool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: could you make this final
?
@apc999, I have made this class final, thanks for the comment ! |
Merged build finished. Test FAILed. |
Test FAILed. Build result: FAILURE[...truncated 2259 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/pom.xml to org.alluxio/alluxio-keyvalue-client/1.1.0-SNAPSHOT/alluxio-keyvalue-client-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/target/alluxio-keyvalue-client-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-client/1.1.0-SNAPSHOT/alluxio-keyvalue-client-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/target/alluxio-keyvalue-client-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-client/1.1.0-SNAPSHOT/alluxio-keyvalue-client-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.1.0-SNAPSHOT/alluxio-underfs-hdfs-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.1.0-SNAPSHOT/alluxio-underfs-hdfs-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.1.0-SNAPSHOT/alluxio-underfs-hdfs-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.1.0-SNAPSHOT/alluxio-underfs-swift-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.1.0-SNAPSHOT/alluxio-underfs-swift-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.1.0-SNAPSHOT/alluxio-underfs-swift-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.1.0-SNAPSHOT/alluxio-examples-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.1.0-SNAPSHOT/alluxio-core-server-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server/1.1.0-SNAPSHOT/alluxio-core-server-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server/1.1.0-SNAPSHOT/alluxio-core-server-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.1.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-server/1.1.0-SNAPSHOT/alluxio-core-server-1.1.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.1.0-SNAPSHOT/alluxio-keyvalue-common-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.1.0-SNAPSHOT/alluxio-keyvalue-common-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.1.0-SNAPSHOT/alluxio-keyvalue-common-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.1.0-SNAPSHOT/alluxio-underfs-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.1.0-SNAPSHOT/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.1.0-SNAPSHOT/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.1.0-SNAPSHOT/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.1.0-SNAPSHOT/alluxio-integration-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.1.0-SNAPSHOT/alluxio-keyvalue-1.1.0-SNAPSHOT.pomchannel stoppedTest FAILed. |
Jenkins,test this please! |
Merged build finished. Test FAILed. |
Merged build finished. Test FAILed. |
Test FAILed. Build result: FAILURE[...truncated 2403 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/pom.xml to org.alluxio/alluxio-underfs-s3a/1.2.0-SNAPSHOT/alluxio-underfs-s3a-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/target/alluxio-underfs-s3a-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-s3a/1.2.0-SNAPSHOT/alluxio-underfs-s3a-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/target/alluxio-underfs-s3a-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-s3a/1.2.0-SNAPSHOT/alluxio-underfs-s3a-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.2.0-SNAPSHOT/alluxio-examples-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.2.0-SNAPSHOT/alluxio-underfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.2.0-SNAPSHOT/alluxio-integration-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.2.0-SNAPSHOT/alluxio-keyvalue-1.2.0-SNAPSHOT.pomchannel stoppedTest FAILed. |
Merged build finished. Test FAILed. |
Test FAILed. Build result: FAILURE[...truncated 2402 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/pom.xml to org.alluxio/alluxio-underfs-s3a/1.2.0-SNAPSHOT/alluxio-underfs-s3a-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/target/alluxio-underfs-s3a-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-s3a/1.2.0-SNAPSHOT/alluxio-underfs-s3a-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/target/alluxio-underfs-s3a-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-s3a/1.2.0-SNAPSHOT/alluxio-underfs-s3a-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.2.0-SNAPSHOT/alluxio-examples-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.2.0-SNAPSHOT/alluxio-underfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.2.0-SNAPSHOT/alluxio-integration-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.2.0-SNAPSHOT/alluxio-keyvalue-1.2.0-SNAPSHOT.pomchannel stoppedTest FAILed. |
Merged build finished. Test PASSed. |
Test PASSed. |
alluxio-bot, check this please. |
Running checks...
All checks passed! |
Closing this PR due to being inactive for a while, feel free to reopen it if you have updates. |
https://alluxio.atlassian.net/browse/ALLUXIO-1825