Wait for file completed in fuse getAttr (#8192) #9496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
|
jenkins, test this please |
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
|
liuhongtong
reviewed
Jul 19, 2019
|
|
||
| URIStatus status = mFileSystem.getStatus(turi); | ||
| if (!status.isCompleted()) { | ||
| if (!waitForFileCompleted(turi)) { |
There was a problem hiding this comment.
Should we consider the mOpenFiles?
There was a problem hiding this comment.
Do you mean to check if it is in mOpenFiles? The file could be closed during the wait period.
This was referenced Jul 19, 2019
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick of #8192
cherry-pick commits are:
change fuse get attr : fb36eea63268
change the error message : 9c78eaa12b36
update status after file completed : 70eb188fa485
fix the getAttr error : c270a101fad6