Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datetime型を分離 #18

Closed
Alma-field opened this issue Oct 3, 2021 · 1 comment · Fixed by #28, #33 or #35
Closed

datetime型を分離 #18

Alma-field opened this issue Oct 3, 2021 · 1 comment · Fixed by #28, #33 or #35
Labels
enhancement New feature or request
Milestone
v1.1 - Update to ...

Comments

@Alma-field
Copy link
Owner

Alma-field commented Oct 3, 2021 •
edited
Loading

現在 複数のクラスにて int を datetime型へ変換している。
これを LateLimit クラスと同様に datetime を int 型へ戻し、
_time サフィックス(接尾辞) を付加したメンバを追加、 datetimeint 型として提供する。

対象クラス

  • Movie
  • Comment
@Alma-field Alma-field added the enhancement New feature or request label Oct 3, 2021
@Alma-field Alma-field added this to the v1.1 - Update to 9/27 milestone Oct 3, 2021
@Alma-field
Copy link
Owner Author

Alma-field commented Oct 4, 2021 •
edited
Loading

後方互換性がなくなるため本来は v2.0 としてリリースするのが正当ではあるが、
一般にダウンロードされていない状態であるため v1.1 リリースに含める
後方互換性の重要性に鑑み、_time サフィックス(接尾辞) を付加したメンバを int 型とし、
その他は以前の状態に戻す。

Alma-field added a commit that referenced this issue Oct 4, 2021
@Alma-field
Update: Separate created into datetime type and int type #18
439758a
Alma-field added a commit that referenced this issue Oct 4, 2021
@Alma-field
Update: Update document #18
483f1e1
Alma-field added a commit that referenced this issue Oct 4, 2021
@Alma-field
Changed to return None if unix_timestamp is None #18
cdad857
Alma-field added a commit that referenced this issue Oct 4, 2021
@Alma-field
Added translation of created attribute close #18
9f6a267
@Alma-field Alma-field linked a pull request Oct 4, 2021 that will close this issue
Feature/#18 separate datetime type #28
Merged
Alma-field added a commit that referenced this issue Oct 4, 2021
@Alma-field
Merge pull request #28 from Alma-field/feature/#18_Separate_datetime_…
36422d7 
…type

Feature/#18 separate datetime type
Alma-field added a commit that referenced this issue Oct 5, 2021
@Alma-field
Update: Swap int and datetime.datetime types #18
921b63b
Alma-field added a commit that referenced this issue Oct 5, 2021
@Alma-field
Update: Update docstring #18
6c56902
Alma-field added a commit that referenced this issue Oct 5, 2021
@Alma-field
Update: Update translation #18
2ddcacc
@Alma-field Alma-field linked a pull request Oct 5, 2021 that will close this issue
Feature/#18 separate datetime type #33
Merged
Alma-field added a commit that referenced this issue Oct 5, 2021
@Alma-field
Merge pull request #33 from Alma-field/feature/#18_Separate_datetime_…
c91980d 
…type

Feature/#18 separate datetime type
@Alma-field Alma-field linked a pull request Oct 5, 2021 that will close this issue
Release v1.1.0 #35
Merged
@Alma-field Alma-field mentioned this issue Oct 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1 - Update to 9/27
1 participant
@Alma-field