-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https to clone build system repos #15
Conversation
While here, remove duplicate entry for alma-tests-cacher. Resolves: AlmaLinux/build-system#182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I not sure that we should switch to https to be honest
Dev deploy is created mainly for development env, and contributing with ssh remote is more convinient because we can push without password authentication
Maybe we can add addtional variable clone_with_ssh = true/false
and based on that variable generate correct remote urls?
I use HTTPS to clone and I add SSH URL to push in my environment.
One of the reasons why I made this pull request is you added HTTPS URL recently. I thought you prefer HTTPS rather than SSH. |
I dont have strong opinion on https vs ssh, but maybe yours example will be the best solution i.e.
I did not found how we can update remote with ansible |
I'm not sure if this will work, but with the git_config module you may be able to do something like this: (untested) - name: Update git repository
hosts: all
tasks:
- name: Update repository fetch url
community.general.git_config:
repo: ./somerepo
name: remote.origin.url
value: https://github.com/codyro/somerepo.git
scope: local
- name: Update repository push url
community.general.git_config:
repo: ./somerepo
name: remote.origin.pushurl
value: git@github.com:codyro/somerepo.git
scope: local |
Added a task to set pushurl as @codyro mentioned. I confirmed it works for me. |
While here, remove duplicate entry for alma-tests-cacher.
Resolves: AlmaLinux/build-system#182