Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish PR #2 #3

Merged
merged 3 commits into from Sep 20, 2016
Merged

Finish PR #2 #3

merged 3 commits into from Sep 20, 2016

Conversation

ulrichb
Copy link
Collaborator

@ulrichb ulrichb commented Sep 20, 2016

See conversation in #2.

@coveralls
Copy link

coveralls commented Sep 20, 2016

Coverage Status

Coverage remained the same at 98.182% when pulling bbfa649 on ulrichb:FinishPR2 into 19024b7 on Alorel:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.182% when pulling bbfa649 on ulrichb:FinishPR2 into 19024b7 on Alorel:develop.

@ulrichb ulrichb mentioned this pull request Sep 20, 2016
4 tasks
@Alorel Alorel merged commit a40aea9 into Alorel:develop Sep 20, 2016
@Alorel
Copy link
Owner

Alorel commented Sep 20, 2016

The demo works just fine, so, if you're happy, I'll merge this into master and release as 2.0 - just say the word. :)

@Alorel
Copy link
Owner

Alorel commented Sep 20, 2016

Additionally, how would you like to be referenced in package.json's contributors section, is the following fine with you?

{
   "name": "ulrichb",
   "url": "https://github.com/ulrichb"
}

@ulrichb
Copy link
Collaborator Author

ulrichb commented Sep 23, 2016

Sry, had no time to answer.

Many thanks for merging! And many thanks for adding me to the contributor list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants