Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GamesDBShaScraper hash_path #356

Closed
GregHolmes opened this issue Jan 20, 2015 · 2 comments
Closed

GamesDBShaScraper hash_path #356

GregHolmes opened this issue Jan 20, 2015 · 2 comments

Comments

@GregHolmes
Copy link

on make, I'm getting this issue. I've attempted to search for any reference online but can't find anything. I'm running stock raspbian and attempting to install emulationstation. Could anyone shed some light on this issue please?

[ 73%] Building CXX object es-app/CMakeFiles/emulationstation.dir/src/scrapers/GamesDBShaScraper.cpp.o
/home/pi/EmulationStation/es-app/src/scrapers/GamesDBShaScraper.cpp: In function ‘boost::filesystem3::path GamesDBShaScraper::get_hash_path()’:
/home/pi/EmulationStation/es-app/src/scrapers/GamesDBShaScraper.cpp:25:15: error: no match for ‘operator+=’ in ‘hash_path += "hash.tsv"’
es-app/CMakeFiles/emulationstation.dir/build.make:606: recipe for target 'es-app/CMakeFiles/emulationstation.dir/src/scrapers/GamesDBShaScraper.cpp.o' failed
make[2]: *** [es-app/CMakeFiles/emulationstation.dir/src/scrapers/GamesDBShaScraper.cpp.o] Error 1
CMakeFiles/Makefile2:246: recipe for target 'es-app/CMakeFiles/emulationstation.dir/all' failed
make[1]: *** [es-app/CMakeFiles/emulationstation.dir/all] Error 2
Makefile:133: recipe for target 'all' failed
make: *** [all] Error 2

@Aloshi
Copy link
Owner

Aloshi commented Jan 20, 2015

Interesting, it looks like the overloaded "+=" operator for boost::filesystem::path isn't working for some reason. Try changing line 23 of es-app/src/scrapers/GamesDBShaScraper.cpp to

boost::filesystem::path hash_path = home + "/.emulationstation/rom_hashes/";

and line 25 to

hash_path = hash_path / "hash.tsv";

and see if that compiles.

If you can't get it to work, you can switch over to the master branch for a working copy (That new scraper stuff was just committed to unstable last night - other than that, the branches are in sync.)

@GregHolmes
Copy link
Author

Thank you!

Altering line 25 to your suggestion resolved the issue. Line 23 was identical to what I had in the file.

Aloshi added a commit that referenced this issue Jan 21, 2015
@Aloshi Aloshi closed this as completed Jan 21, 2015
mmatyas pushed a commit to mmatyas/EmulationStation that referenced this issue Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants