Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buy ETH button to bottom of Wallet tab #5398

Closed
hboon opened this issue Sep 16, 2022 · 7 comments · Fixed by #5501
Closed

Add Buy ETH button to bottom of Wallet tab #5398

hboon opened this issue Sep 16, 2022 · 7 comments · Fixed by #5501
Assignees
@oa-s
Labels
High Priority

Comments

@hboon
Copy link
Member

hboon commented Sep 16, 2022

  • Only if Ethereum mainnet is enabled
  • Works like the "Buy" button when we tap "Buy" after tapping the ETH token > … > Buy

Something like Android's:
@hboon
Copy link
Member Author

hboon commented Sep 26, 2022

Actually a better reference: it is also available as "Buy Crypto" in Wallet > …

@oa-s
Copy link
Contributor

oa-s commented Sep 28, 2022

any suggestions of how to make floating footer, to make it snap to content bottom, in case when content size is less then
table view frame, and snap it to table view's bottom when content size greater than frame height?

@hboon
Copy link
Member Author

hboon commented Sep 28, 2022

Not necessary I think. But if you want, make it float at the bottom if there is only < say 3 tokens ad adjust the table view inset?

@hboon
Copy link
Member Author

hboon commented Oct 4, 2022

@vladyslav-iosdev in case you forgot :)

@oa-s
Copy link
Contributor

oa-s commented Oct 4, 2022

working on it, no success with its floating :(

@hboon
Copy link
Member Author

hboon commented Oct 4, 2022

Doesn’t have to float :)

@oa-s
Copy link
Contributor

oa-s commented Oct 4, 2022

ok, making it to snap to table view bottom, found an issue when keyboard appears, working on it, will attach video of an issue

oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Oct 4, 2022
@oa-s
Add Buy ETH button to bottom of Wallet tab AlphaWallet#5398
4c43319
@oa-s oa-s mentioned this issue Oct 4, 2022
Merged
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Oct 4, 2022
@oa-s
Add Buy ETH button to bottom of Wallet tab AlphaWallet#5398
9cc1fe1
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Oct 5, 2022
@oa-s
Add Buy ETH button to bottom of Wallet tab AlphaWallet#5398
5bd9f59
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Oct 5, 2022
@oa-s
Add Buy ETH button to bottom of Wallet tab AlphaWallet#5398
0d48a07
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Oct 5, 2022
@oa-s
Add Buy ETH button to bottom of Wallet tab AlphaWallet#5398
389eb2b
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Oct 5, 2022
@oa-s
Add Buy ETH button to bottom of Wallet tab AlphaWallet#5398
666e4aa
oa-s added a commit to oa-s/alpha-wallet-ios that referenced this issue Oct 6, 2022
@oa-s
Add Buy ETH button to bottom of Wallet tab AlphaWallet#5398
632669c
@oa-s oa-s closed this as completed in #5501 Oct 6, 2022
oa-s added a commit that referenced this issue Oct 6, 2022
@oa-s
Merge pull request #5501 from oa-s/#5398
74e919f 
Add Buy ETH button to bottom of Wallet tab #5398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oa-s oa-s

Labels
High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Buy ETH button to bottom of Wallet tab #5398 oa-s/alpha-wallet-ios
2 participants
@hboon @oa-s