-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow stopping api server when watch command is stopped #922
Allow stopping api server when watch command is stopped #922
Conversation
build failed |
for tesflows pass
edit run tests
commit changed cli.py.cli.snapshot |
Pull Request Test Coverage Report for Build 9132124402Details
💛 - Coveralls |
All looks good now, thanks for contribution small step before merge |
73623da
to
42a6946
Compare
Thanks for helping with this. I think because I rebased master I need to get a new workflow approval in order to merge this |
Hi, with the current
--watch
implementation on the API server, if error occurs in thewatch
goroutine, process just stops leaving API server running without performing any work and you need to manually restart the server orstart
watch command by the API call in order to have it running again.I think it would make sense to stop API server if
watch
command failed so I am proposing a change that allows runningwatch
command as a main API process and once its stopped, whole server is stopped as well.Added this feature under a new
watch_is_main_process
config argument so it is backwards compatible and will not introduce new behaviour in the tool without explicitly enabling it.fix #923
Does this change make sense and I could expect it to be introduced in the system?