exit the application once watch is stopped #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadus21
commented
May 30, 2024
| api.log.Errorf("Watch error: %v", err) | ||
| return | ||
| } | ||
| api.handleWatchResponse(commandId, err) |
There was a problem hiding this comment.
missed this case in the previous PR so fixing it as well
|
@Slach don't have permissions to add you as a reviewer so tagging you in the comment |
Pull Request Test Coverage Report for Build 9306204339Details
💛 - Coveralls |
Slach
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PR that I've made couple weeks before. Noticed that my solution actually does not end
Runfunction and the process keeps hanging indefinitely. To fix this added another channel which would notify that the server/process needs to be stopped.