Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm chart generator to treat config.yaml as yaml in values #1317

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

echozio
Copy link
Contributor

@echozio echozio commented Jan 28, 2024

This addresses some of the concerns raised in #1138 and leaves the contents of config.yaml as YAML in values.yaml, enabling users to change a single value without the need to copy the rest of its contents over to their own values.

Users already using a string for their config.yaml value should not be affected, as the template partial responsible for rendering the data treats any top-level string value as before. This behavior was also necessary to retain in order to render the ConfigMaps with non-YAML data.


  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

@Slach
Copy link
Collaborator

Slach commented Jan 28, 2024

thanks for contribution
hope not so much users used config.yml provided as string

@Slach Slach closed this Jan 28, 2024
@Slach Slach reopened this Jan 28, 2024
@Slach Slach merged commit ce552cf into Altinity:0.23.0 Jan 28, 2024
Slach added a commit that referenced this pull request Jan 28, 2024
Signed-off-by: Slach <bloodjazman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants