-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It should be possible to adjust the sizes of the panels by dragging them narrower or wider #12787
Comments
Create new hook |
Linked with #12730, and should be implemented in the same way |
TestingNice work on a feature that is super nice to finally have in Studio 👏 Should we add a min-width for the two middle columns in the Lage page, so that it is not possible to hide them entirely? 20240715-0646-17.2517201.mp4This one is more a personal opinion, but I think this feature would look cleaner without the hover effect on the resize handle. To me, the Studio UI appears more solid without it. What do you think? Here's a video where the hover effect is disabled: 20240715-0703-59.5373789.mp4Other than this, it looks like it works perfectly, both in Datamodell and Lage 😊 |
I also have two small comments on this one;
Skjermopptak.2024-07-15.kl.10.58.07.movBut need to add that this was a nice feature to finally get in Studio 🤩 It will be even better as soon as we store the chosen sizes 👏 |
This looks really nice! Love this feature! I have a small comment on what @ErlingHauan mentioned:
In the refinement of this task, didn't we discuss having the same effect as in the preview? When the config and pages columns get narrow enough, shouldn't they be hidden with a button, similar to the preview? |
@ErlingHauan Good catch on the preview collapsing issue, i agree, a min-width on the center columns make sense 👍 For the on-hover effect, i am fairly neutral to the two options, but I do see your point on it feeling more solid. I will make changes for both. |
I agree, especially since collapsed state is not persistent.
Thanks for noticing this. It is definitely an unintended issue that the content accordion's content is not resizing as it used to before. |
@standeren @ErlingHauan test-feedback-resizable.mp4 |
I noticed one more thing: it is not possible to click and drag the scrollbars any more: 20240717-0705-47.6720153.mp4 |
This is interesting, it works in firefox as the scrollbar is different and wider. I have tried to find a solution that does not alter the scrollbar or make the draggable handle area very small, but have found no solutions yet. We could possibly solve this by styling the scrollbar on webkit-based browsers wider, as we are using Maybe this should be discussed? |
Ouch, that doesn't look very good! 😄 According to this article, Firefox, Chrome, and Edge are starting to support the official scrollbar standard, while Safari is lagging behind. Maybe we should revisit how we style the scrollbars in a separate issue? |
Good find 👍 Agreed, i think we should revisit this. I created a new issue referencing your comment. |
The user should be able to control the space usage here and adjust the panels. The preview and component panels should also be able to be hidden if the user desires
The text was updated successfully, but these errors were encountered: