Fix click-and-hold scrolling in Designer #13194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
solution/studio/designer
Jondyr
pushed a commit
that referenced
this pull request
Jul 22, 2024
Jondyr
added a commit
that referenced
this pull request
Jul 29, 2024
) * Change `AppPreviewBar` LegacySelect to StudioNativeSelect * Change `SecurityLevelSelect` LegacySelect to StudioNativeSelect * Change `LangSelector` LegacySelect to StudioNativeSelect * Remove selected property from <option> * Change `SchemaInspector` LegacySelect to StudioNativeSelect * Change `PolicyCardRules` LegacySelect to StudioNativeSelect * Use defaultValue instead of selected on <option> * Change `TextResourceEditor` LegacySelect to StudioNativeSelect * Change `componentSpecificContent` LegacySelect to StudioNativeSelect * Delete unused code * Change `componentconfig` LegacySelect to StudioNativeSelect Remove unused import * Fix some tests broken after LegacySelect->StudioNativeSelect swap Fix some tests broken after LegacySelect->StudioNativeSelect swap * Fix failing `each()` tests * Replace LegacyTextField with StudioTextfield in schemainspector * Fix css after replacing legacy components * Replace LegacyTextField and fix possible bug with saving float numbers Bug: saving float numbers for min/max restrictions on number components * Fix formatting * Replace LegacyTextField for ux-editor, delete unused code * Fix tests after replacing LegacyTextField * Fix interesting test failure, new component allows exponents like 1e2 "1test 2" becomes "1e2" = 1*10^2=100 * Fix tests using wrong role for number input * Widen test for coverage * Add tests for combobox enum with multiple selection Remove unused code Fix accidental deletion of test value * Fix formatting, prettier * Merge main test fixes * Fix playwright test failing after legacy component replacement * fixed overfloee in datamodellknytninger accordion * fixes overflow in datamodel bilnding in featureFlag * Replace LegacyPopover for ReleaseContainer * Replace LegacyPopover for datamodel deletion button * Replace LegacyPopover for AltinnConfirmationDialog * Change AltinnConfirmationDialogProps to use StudioPopoverProps * Replace LegacyPopover for ThreeDotsMenu * Replace LegacyPopover in PreviewLimitationsInfo * Replace LegacyTable for TextList * Fix click-and-hold scrolling in designer (#13194) * Fix dashboard URL in Playwright (#13203) * eid logger deploy env setup (#13205) * Update dependency org.springframework.boot:spring-boot-starter-parent to v3.3.2 (#13198) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * change helm repository (#13208) * pass bools as strings in helm chart(#13209) * Add missing ids to nativeselect, required for label `for` * Fix playwright tests failing after LegacySelect replacement Also change value assertion to follow playwright best practices: **NOTE** If you need to assert input value, prefer [expect(locator).toHaveValue(value[, options])](https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-have-value) to avoid flakiness. See [assertions guide](https://playwright.dev/docs/test-assertions) for more details. Fix typo * Make sure ids for tablerowtype is unique in a multi type list * Replace LegacyToggleButtonGroup on the preview page * Fix app preview tests for togglegroup button -> radio * Replace legacyfieldset for mapcomponent * Replace LegacyTextArea in ItemDataComponent * Update import from storybook entry for resizablelayout * Replace legacy components for ux-editorv3 * Remove design-system-react dependency Squash: Also commit `yarn.lock` * Fix linting issues * Update SelectDataModelComponent.test.tsx * Fix informative message variant validation issue * Fix some event handling collisions between new and old components * Remove commented unused css * Merge main * Use `useId` hook to generate unique fallback id for StudioNativeSelect * Revert change to button disabled property check in langselector test * Add name option back to getRole query --------- Co-authored-by: JamalAlabdullah <jamal.mustafa.alabdullah@digdir.no> Co-authored-by: Erling Hauan <148075168+ErlingHauan@users.noreply.github.com> Co-authored-by: Tomas Engebretsen <tomas.engebretsen@digdir.no> Co-authored-by: Mirko Sekulic <misha.sekulic@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solution was inspired by Rider/Windows, which appears to work the same way:
fixScrollbars.mp4
Related Issue(s)
Verification