-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/recipt superflous title submitted #65
Conversation
…are no attachments to show
…l, since it should follow the title)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff 🙂 Left a couple of minor comments
Co-authored-by: Håkon <2082481+haakemon@users.noreply.github.com>
…element in test, removing redundant comments
…are no PDF attachments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 💯
Minor nitpicking I just find more pleasing for the eyes. Merge only if you agree.
Co-authored-by: Steffen Lorang Ekeberg <steffen.ekeberg@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! And an annoying thing. These AltinnReceipt
and AltinnAttachment
-components are currently duplicated in our altinn-studio repo - which are used by the receipt platform component.
I think we need to duplicate this PR to also get this fix out there as well.
Kudos, SonarCloud Quality Gate passed! |
Description
Hiding titleSubmitted when no pdfs are passed, as per referenced issue
Fixes
Følgende er sendt inn
if no elements are present altinn-studio#8296Verification
Documentation