Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/recipt superflous title submitted #65

Merged
merged 8 commits into from
Apr 28, 2022

Conversation

olemartinorg
Copy link
Contributor

@olemartinorg olemartinorg commented Apr 27, 2022

Description

Hiding titleSubmitted when no pdfs are passed, as per referenced issue

Fixes

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

Copy link
Contributor

@haakemon haakemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff 🙂 Left a couple of minor comments

src/shared/src/components/organisms/AltinnReceipt.test.tsx Outdated Show resolved Hide resolved
src/shared/src/components/organisms/AltinnReceipt.tsx Outdated Show resolved Hide resolved
Co-authored-by: Håkon <2082481+haakemon@users.noreply.github.com>
Ole Martin Handeland added 2 commits April 27, 2022 15:46
Copy link
Contributor

@mjulstein mjulstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@lorang92 lorang92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 💯

Minor nitpicking I just find more pleasing for the eyes. Merge only if you agree.

src/shared/src/components/organisms/AltinnReceipt.tsx Outdated Show resolved Hide resolved
src/shared/src/components/organisms/AltinnReceipt.tsx Outdated Show resolved Hide resolved
Co-authored-by: Steffen Lorang Ekeberg <steffen.ekeberg@gmail.com>
Copy link
Contributor

@lorang92 lorang92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! And an annoying thing. These AltinnReceipt and AltinnAttachment-components are currently duplicated in our altinn-studio repo - which are used by the receipt platform component.

I think we need to duplicate this PR to also get this fix out there as well.

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants