fix stp #42
Merged
fix stp #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6293
commented
Jan 12, 2022
| @@ -469,14 +469,9 @@ impl InstructionSet for ArithmeticOp { | |||
| reg, | |||
| idx, | |||
| regs.get(reg, idx).and_then(|val| { | |||
| if step.as_i16() < 0 { | |||
| val.int_sub(Number::from(-step.as_i16()), IntFlags { | |||
There was a problem hiding this comment.
When applying Stp to A8 register, we are not sure that the step value (which is stored as i16) is within the scope of 8 bits. Maybe we should make Step i8, or add a method on Number that check if a number is representable in target bits (reshape method does not check that. it always returns false if a target bits are less than current bits)
There was a problem hiding this comment.
Very good point! I think we need to reduce step down to u8 - but we need to make sure that the byte command is updated correspondingly. Let's do it as a separate PR (or pls open an issue for that just not to forget)
|
@dr-orlovsky btw have you checked DM from me on Twitter? |
dr-orlovsky
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #36