Add ability to override back button #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranunez
reviewed
Jan 16, 2017
| @@ -16,7 +16,7 @@ extension PDFViewController { | |||
| /// - parameter actionStyle: sytle of the action button | |||
There was a problem hiding this comment.
Make sure documentation gets updated accordingly
|
@benbahrenburg Thanks this looks good! Make sure the function's documentation gets updated accordingly for this new parameter, and update the README with this new customization option |
|
@ranunez updated the read me and the code comments. Let me know if there is anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for a great project. I have a use case that I need a custom back button. I've added it as optional in the create controller. I thought it might be helpful for others.