Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for signals bug in Angular #146

Merged
merged 2 commits into from Sep 19, 2023

Conversation

divdavem
Copy link
Member

When upgrading Angular to version 16.2.4, our previous workaround for angular/angular#50320 no longer works. This PR implements another workaround.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #146 (5cbc445) into main (f16fde2) will increase coverage by 0.00%.
The diff coverage is 93.75%.

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   88.31%   88.32%           
=======================================
  Files          52       52           
  Lines        1386     1387    +1     
  Branches      218      219    +1     
=======================================
+ Hits         1224     1225    +1     
  Misses        125      125           
  Partials       37       37           
Flag Coverage Δ
e2e-1 62.27% <75.00%> (+0.03%) ⬆️
e2e-2 39.90% <93.75%> (+0.24%) ⬆️
e2e-4 65.25% <ø> (ø)
e2e-5 50.20% <ø> (ø)
e2e-7 59.02% <ø> (ø)
e2e-8 55.63% <ø> (ø)
unit 91.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
angular/lib/src/lib/modal/modal.component.ts 77.41% <ø> (-1.37%) ⬇️
angular/headless/src/lib/use.directive.ts 84.21% <93.75%> (+2.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@divdavem divdavem marked this pull request as ready for review September 18, 2023 16:24
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Please open an issue to track the recovery of this workaround.

@divdavem
Copy link
Member Author

@quentinderoubaix Thank you for your review

@divdavem divdavem merged commit b0d09e0 into AmadeusITGroup:main Sep 19, 2023
13 checks passed
@divdavem
Copy link
Member Author

divdavem commented Sep 19, 2023

Please open an issue to track the recovery of this workaround.

I have opened this issue: #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants