Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client]Update resposne body when request failed #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tuteng
Copy link

@tuteng tuteng commented Dec 6, 2022

Fixes #xyz

Master Issue: apache#16691

Motivation

When using pulsar-admin and encountering an exception, first check the body, then check the http text

Modifications

  • Update http response body check

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@tuteng tuteng changed the title Update resposne body when request failed [pulsar-client]Update resposne body when request failed Dec 6, 2022
@tuteng tuteng changed the title [pulsar-client]Update resposne body when request failed [fix][pulsar-client]Update resposne body when request failed Dec 6, 2022
@tuteng tuteng changed the title [fix][pulsar-client]Update resposne body when request failed [fix][client]Update resposne body when request failed Dec 12, 2022
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant