Fix menu resolving #1429
Merged
Fix menu resolving #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leksat
force-pushed
the
fix-menu-resolving
branch
from
c325d93
to
9e4ab7a
Compare
Using the same workaround as in MenuFeed::resolveTranslations().
pmelab
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package(s) involved
amazeelabs/graphql_directivesMotivation and context
It was noticed that menu related
load*queries were ignoring the passed menu language. This was messing up Gatsby's partial builds. Gatsby was not reacting to changes in menu item translations.Related Issue(s)
#1274
How has this been tested?
Added a unit test case. Tested manually on silverback-template.