forked from endless-sky/endless-sky
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hai Reveal Introduction Rework #27
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… they are already in cargo (endless-sky#8688) fix
…ai worlds, not uninhabited ones (endless-sky#8690)
Add support for building for Flatpak with CMake.
* Add a pointer beside selected ships instead of changing the icon color. * Add a specific color for disabled ships, instead of using the "elsewhere" color.
endless-sky#8293) * "ignore clearance" missions will offer even if player has no clearance at destination
Co-authored-by: ChamEV <51398924+ChamEV@users.noreply.github.com>
…hips (endless-sky#8715) Co-authored-by: TomGoodIdea <108272452+TomGoodIdea@users.noreply.github.com>
* No longer show a message when the ship being scanned is the player's flagship or when the scan will result in a fine if successful.
… a while even if they have nothing to do (endless-sky#8125)
…tfit that is also in storage (endless-sky#8749)
…mp drive is available to take (endless-sky#8772)
I was deleting old missions as I replaced them, so the intro file is now just scrap pieces of stuff I didn't make use of yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is an almost total rework of the introductory chapter to Hai Reveal. The existing introduction has many issues, some of which are highlighted in endless-sky#7527 and endless-sky#8268.
The Issues
A general summary of these issues which this PR seeks to address is as follows:
Overview of Changes
As such, this PR makes the following changes:
The Specifics
"hr: secret leaks"
condition is set. This condition is used to kick off the news reports in FW and Republic or Syndicate space. This also sets off timed events that determine when characters from the main campaign arrive in Hai space.The Future of Hai Reveal
You may notice that this introduction has no connection to the rest of the HR storyline after it, meaning that this introduction is all that will be playable. I spoke with Grey, and he agreed to releasing HR in stages. Sections of HR will be worked on and then released when they are finalized. As such, this PR also once again disconnects the Wanderer campaign from the Hai Reveal storyline. Notably, this will result in Sayari potentially being in two places at once at the moment, and the HR storyline will act as if you have not done anything in the Wanderer campaign (including meeting Sayari and getting the translation device). This is intentional, as we intend to still have Hai Reveal being a prerequisite for most of the Wanderer storyline, similar to how the main campaign is currently a prerequisite to most of the Wanderer storyline. That is, players will still be able to engage with the Wanderers without having first done Hai Reveal and make some progress in the Wanderer storyline, but there will eventually be a point where Hai Reveal will need to be completed. This blocking of the Wanderer storyline will only be put in place after Hai Reveal has been finalized, though.