Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML 404 File #11

Merged
merged 5 commits into from Jan 11, 2016
Merged

Add HTML 404 File #11

merged 5 commits into from Jan 11, 2016

Conversation

Digi59404
Copy link

Google/Bing place very high priority on sane 404 pages. Not to mention from a marketing standpoint a sane 404 page can make the difference between leaving a website and being sucked into another article.

This PR allows for a basic 404.html file to be used - Ideally a 404 Controller should exist for dynamics and fun. But for right now - this will work.

Give users a pretty 404 page instead of a blank page.

@nmelnick
Copy link
Member

Thanks for the contribution! Admittedly, I think I just expected the front web server to handle the 404 and show another page, but this is great for an enclosed environment or against a server that won't do it.

nmelnick added a commit that referenced this pull request Jan 11, 2016
@nmelnick nmelnick merged commit 3911838 into AmbitionFramework:master Jan 11, 2016
@Digi59404
Copy link
Author

Welcome! More will be coming! I have a bunch more to add.

I run ambition in front of Nginx - But I know for numerous enterprise and marketing reasons companies and groups like to have their own 404's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants