[FIX] add venv support #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdkerr
suggested changes
Mar 6, 2018
| -- set some variable. But the variables are differently named and we would never | ||
| -- get them all, so try to parse the env name out of the PROMPT. | ||
| -- envs are usually put in round or square parentheses and before the old prompt | ||
| local env = old_prompt:match('.*%([.*]%)%sλ') |
There was a problem hiding this comment.
use {lamb} here instead of the raw character?
There was a problem hiding this comment.
I think this PR has to be refactored to fit the new segment approach
|
@lionel-deglise would you be able to rebase and update your PR? |
|
I got it to work with the new segment system. However, this repo seems to be dead. Is there a point in submitting a new PR for this? Not as fancy as the solution in #37, just showing the virtual env between parenthesis before the prompt symbol (as it is in "default" cmder).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add env (ex: Python venv) support by searching env in () or [] before lambda in Cmder prompt