Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fonts #2

Closed
wants to merge 1 commit into from
Closed

Added Fonts #2

wants to merge 1 commit into from

Conversation

In-evitable
Copy link
Contributor

Added:

  • JetBrains Mono
  • Roboto Mono

Added:
- JetBrains Mono
- Roboto Mono
@AmraniCh
Copy link
Owner

Hey, thanks for your PR.

The Google fonts links that's you added are including also italic styles, and unfortunately the italic styles are not supported by this extension (should be supported in the next versions), so please edit the links so they can include only regular styles, thank you!

@In-evitable
Copy link
Contributor Author

Your welcome! I tried the extension with the fonts I added from my fork. It worked just like charm. I get your point, but it wont affect the extension by adding italics.

@AmraniCh
Copy link
Owner

Ehmm, it works but the weights dropdown elements will be doubled and this may confuse people who use this extension.

ScreenShot_20210912162651

@In-evitable
Copy link
Contributor Author

I created a new pull request with two new fonts and I removed all the italics. Kindly check it out.

@AmraniCh AmraniCh closed this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants