Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unconditional http:// prefix. #1165

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fixing unconditional http:// prefix. #1165

merged 1 commit into from
Jan 3, 2023

Conversation

JadinHeaston
Copy link

@JadinHeaston JadinHeaston commented Jan 3, 2023

First time contribution (ever, woo!).

Fixes issue: #1165

Adds a check in addHttp() to see if mailto: or tel: is present before attempting to append http://.

Thanks!

…` is present.Signed-off-by: Jadin Heaston <jadin.heaston@como.gov>
@JadinHeaston JadinHeaston changed the title ISSUE: #1143 - Fixing unconditional http:// prefix. Fixing unconditional http:// prefix. Jan 3, 2023
@AmruthPillai AmruthPillai linked an issue Jan 3, 2023 that may be closed by this pull request
2 tasks
@AmruthPillai
Copy link
Owner

Congratulations on your first contribution to open source software! 💯 Hope the momentum stays, cause it's a good place to be. Thank you very much for making Reactive Resume better :)

The PR looks good to me 👍🏻

@AmruthPillai AmruthPillai merged commit 322178e into AmruthPillai:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] All email links are broken due to the unconditional http:// prefix
2 participants