Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stewardship incubation text #697

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

ericherman
Copy link
Contributor

Co-authored-by: Felix Faassen felix@publiccode.net

Description

Add text to README and CONTRIBUTING to mention the roles of the Product
and Technical Steering groups and the Foundation.

Signalen#108

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Documentation has been updated if needed
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on master and is up to date with master
  • Check that the PR targets master
  • There are no merge conflicts
  • There are no conflicting Django migrations

How has this been tested?

(Not applicable)

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 90% (the higher the better)
  • No iSort issues are present in the code
  • No Flake8 issues are present in the code

Add text to README and CONTRIBUTING to mention the roles of the Product
and Technical Steering groups and the Foundation.

Signalen#108

Co-authored-by: Felix Faassen <felix@publiccode.net>
@tcoenen tcoenen self-assigned this Jan 26, 2021
Copy link
Contributor

@tcoenen tcoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akkoord!

@tcoenen tcoenen merged commit 71d5728 into Amsterdam:master Jan 26, 2021
@ericherman ericherman deleted the fpc-issue-108 branch January 27, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants