Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Linux setup #335

Closed
uiytt opened this issue Jun 22, 2021 · 2 comments · Fixed by #358
Closed

Better Linux setup #335

uiytt opened this issue Jun 22, 2021 · 2 comments · Fixed by #358
Labels
OS: Linux type: enhancement New feature or request

Comments

@uiytt
Copy link

uiytt commented Jun 22, 2021

Currently, Linux user need to manually install wxPython in order to use Amulet.
This is because the default wxPython won't work for every linux os.
So, some linux os can use pip to install it, and some other need to build it themselves

As mentioned in #281 , it could be possible to generate a specific requirement.txt for each OS in setup.py
(It's possible to get the name of the Linux OS using os.uname()[1])

@Podshot Podshot added OS: Linux type: enhancement New feature or request labels Jun 22, 2021
@cebtenzzre
Copy link

cebtenzzre commented Jun 22, 2021

I don't get what you mean by "the default wxPython won't work for every linux os", pip install wxPython builds wxPython from source on Linux. This directory listing shows builds for CentOS, Debian, Fedora, and Ubuntu, but those are only available via package managers and the wxPython website (AFAIK).

Having wxPython in requirements.txt doesn't stop users from installing their distro's wxPython package first to skip the long build time (~8 minutes on my computer), but leaving it out allows for a broken install which is probably more confusing.

@uiytt
Copy link
Author

uiytt commented Jun 22, 2021

I don't get what you mean by "the default wxPython won't work for every linux os", pip install wxPython builds wxPython from source on Linux. This directory listing shows builds for CentOS, Debian, Fedora, and Ubuntu, but those are only available via package managers and the wxPython website (AFAIK).

Having wxPython in requirements.txt doesn't stop users from installing their distro's wxPython package first to skip the long build time (~8 minutes on my computer), but leaving it out allows for a broken install which is probably more confusing.

This issue was initially risen by @gentlegiantJGC . It seems from this website, that some OS need to actually build it with something else than just pip.
I personally agree that it's better to have something that work for most Linux os and leaving the other build their own version, instead of something that broke for all versions. (

This post is here to find something that would work for all OS and decide if yes or no wxPython should be installed automatically for Linux os.

gentlegiantJGC added a commit that referenced this issue Jun 30, 2021
If this causes issues we can change it back.
#335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: Linux type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants