Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze requirements in the build system #354

Closed
gentlegiantJGC opened this issue Jun 28, 2021 · 0 comments · Fixed by #358
Closed

Freeze requirements in the build system #354

gentlegiantJGC opened this issue Jun 28, 2021 · 0 comments · Fixed by #358

Comments

@gentlegiantJGC
Copy link
Member

The build system should freeze the requirements and replace the requirements.txt
This will make sure that if a user updates the program it will always get the required dependency rather than leaving the old version.
It also means that if we accidentally break something in a future release of the dependencies the old versions will still work.
gentlegiantJGC added a commit that referenced this issue Jun 30, 2021
@gentlegiantJGC
Freeze the first party requirements before uploading to pypi
9e8733d 
Users installing from source needed to manually update the dependencies which caused issues.
This will force the latest version of the first party libraries at build time.
It will also fix some other issues that may present themselves.
#354
@gentlegiantJGC gentlegiantJGC mentioned this issue Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix requirements Amulet-Team/Amulet-Map-Editor
1 participant
@gentlegiantJGC