Improved operations and fixed pick block #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation
and added a bit of documentation
The BaseToolUI class was doing too much so this has been stripped back to a bare API. Its logic has been moved into DefaultBaseToolUI along with the camera behaviour.
also fixed some imports
Previously the operation tool controlled the camera, box and rendering behaviour. This has now been moved into the operations themselves so that they can in theory control the editor in the same way that tools can.
If _show_pointer is set to True or a number greater than or equal to 1 a one box wide pointer will be drawn. It also adds a method _on_box_click which will be run each time the box click action is run (default left mouse) This makes it easy to set up the block pick dropper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously operations were very limited and all of the rendering and behaviour logic was done in the parent tool.
This changes that and moves all the logic into the operation itself.
The
OperationUIclass has been stripped back to a bare API and the logic has been moved into the subclassDefaultOperationUI.If you want to retain the default behaviour (including rendering, camera movement and some other things) you will need to switch the class that you subclass.
If instead you want to define your own interaction and rendering behaviour you can do so by subclassing
OperationUIand adding on the behaviour.The
unloadmethod is nowdisableto make it have the same API as tools so you will need to rename those methods.Finally
EVT_BOX_CLICKhas been removed. The trigger for it was removed a while back but it has stayed because things were still importing it. This logic can be achieved by listening toEVT_INPUT_PRESSon the canvas and checking theaction_idof the event.If you are using
DefaultOperationUIthat logic has been handled for you and the method_on_box_clickwill be run when this action is run. Define this method in the subclass to run the desired code.With these changes to give the operations more control it is now possible to re-implement the pick block tool.