Add support for bubble columns #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for bubble column visibility. Textures made by @kirikarma Also made a small refactor in the VisibleBarriersCommon class to clean up adding item variants in the creative tab.
omoflop
changed the title
|
Hell yeah, the mod is gonna be overhauled at some point but this is definitely gonna be a mainstay feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for bubble column visibility.
Textures made by @kirikarma
Also made a small refactor in the VisibleBarriersCommon class to clean up adding item variants in the creative tab.
Finally, there was an odd crash relating to particles from breaking bubble column blocks, so I created a mixin to disable fluid blocks from having break particles (See client/ParticleManagerMixin). If this is an issue or there is a way around this crash I am not aware of, please let me know.