Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set command empty value #8

Closed
BannukDE opened this issue Aug 24, 2017 · 2 comments
Closed

set command empty value #8

BannukDE opened this issue Aug 24, 2017 · 2 comments
Labels

Comments

@BannukDE
Copy link
Contributor

BannukDE commented Aug 24, 2017

In line 24 of set.js:
if (!value) seems to be always false as u can parse "nothing".
After parsing "nothing" you can not change it back via "set edit key value" as the empty key can not be found by: if (!settings[key])

My solution for now:
if (!value && value == "")

@YorkAARGH
Copy link
Member

YorkAARGH commented Aug 24, 2017 via email

@eslachance
Copy link
Contributor

You're correct that the condition doesn't work, but wrong about the reason. value being an array, an empty array is truthey, not falsey, so that's the issue.

Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants