Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements namely for the times when the help msg is too long #32

Merged
merged 6 commits into from
Nov 23, 2017

Conversation

nathanielcwm
Copy link
Contributor

i have also changed the specific help msg a slight bit reverse that if u don't like it

@YorkAARGH
Copy link
Member

I thank you for bringing this to my attention, I implemented something like this in my bot repo, but I forgot to add it to the guidebot repos,

If you could update your PR by adding a zero-width space in front of the category name, which means you can split by that and have a beautifully organised help menu, I will happily accept your PR.

@nathanielcwm
Copy link
Contributor Author

ok sure!

@nathanielcwm
Copy link
Contributor Author

@YorkAARGH i think i have it in however it only splits it on the last cat that should be ok right?

@YorkAARGH
Copy link
Member

YorkAARGH commented Nov 21, 2017 via email

@YorkAARGH
Copy link
Member

Any chance you can fix the mistakes? (You used single quotes instead of double)

@nathanielcwm
Copy link
Contributor Author

ok no prob

@nathanielcwm
Copy link
Contributor Author

@YorkAARGH

@nathanielcwm
Copy link
Contributor Author

wait fixing the other problems

@YorkAARGH
Copy link
Member

Okay, final 2 things, 1) Do you have a screenshot to show the 'aliases' stuff? and 2) you are aware that it's an array right?

@nathanielcwm
Copy link
Contributor Author

wait 1 moment

@nathanielcwm
Copy link
Contributor Author

image

@nathanielcwm
Copy link
Contributor Author

nathanielcwm commented Nov 21, 2017

yeah ik its an array wait would this be better:
aliases:: ${command.conf.aliases.toString()} @YorkAARGH

@YorkAARGH
Copy link
Member

try .join(", ")ing the array

@nathanielcwm
Copy link
Contributor Author

thanks makes it look much nicer @YorkAARGH

@YorkAARGH YorkAARGH merged commit bcede97 into AnIdiotsGuide:master Nov 23, 2017
@nathanielcwm nathanielcwm deleted the patch-1 branch November 23, 2017 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants