-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combo box selected #1934
Combo box selected #1934
Conversation
@@ -1,5 +1,7 @@ | |||
:host { | |||
display: block; | |||
position: relative; | |||
z-index: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if can avoid using z-index
selectedChanged$ = this._parent.injector.get(NgControl).valueChanges.pipe(tap(selected => { | ||
|
||
if (selected && selected === this.value) { | ||
console.log(this.el.nativeElement.outerHTML); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log
import { ComboBoxTriggerComponent } from '../combo-box-trigger/combo-box-trigger.component'; | ||
import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms'; | ||
import { ControlValueAccessor, NG_VALUE_ACCESSOR, NgControl } from '@angular/forms'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check imports
@@ -52,7 +52,7 @@ | |||
Public | |||
</ansyn-combo-box-option> | |||
|
|||
<ansyn-combo-box-option value="private" [disabled]="true"> | |||
<ansyn-combo-box-option value="private" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readd [disabled]="true", also consider making it attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
No description provided.