Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-index 0.4.0 & noarch #3

Merged
merged 2 commits into from
Jan 30, 2024
Merged

conda-index 0.4.0 & noarch #3

merged 2 commits into from
Jan 30, 2024

Conversation

jezdez
Copy link

@jezdez jezdez commented Jan 29, 2024

conda-index 0.4.0

Destination channel: defaults

Explanation of changes:

  • add Python 3.12 support (via noarch)
  • release latest 0.4.0 version

@jezdez jezdez requested a review from dholth as a code owner January 29, 2024 14:29
@JeanChristopheMorinPerso
Copy link

JeanChristopheMorinPerso commented Jan 29, 2024

Tests are failing with

2024-01-29T14:31:20.733223+00:00  | INFO     |   ______________ ERROR collecting tests/test_groupby_strategies.py _______________
2024-01-29T14:31:20.734388+00:00  | INFO     |   ImportError while importing test module '$SRC_DIR/tests/test_groupby_strategies.py'.
2024-01-29T14:31:20.735536+00:00  | INFO     |   Hint: make sure your test modules/packages have valid Python names.
2024-01-29T14:31:20.736685+00:00  | INFO     |   Traceback:
2024-01-29T14:31:20.73783+00:00   | INFO     |   tests/test_groupby_strategies.py:8: in <module>
2024-01-29T14:31:20.738989+00:00  | INFO     |       from tlz import groupby as toolz_groupby
2024-01-29T14:31:20.740169+00:00  | INFO     |   E   ModuleNotFoundError: No module named 'tlz'
2024-01-29T14:31:20.741409+00:00  | INFO     |   
2024-01-29T14:31:20.742566+00:00  | INFO     |   During handling of the above exception, another exception occurred:
2024-01-29T14:31:20.743711+00:00  | INFO     |   ../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.11/importlib/__init__.py:126: in import_module
2024-01-29T14:31:20.744857+00:00  | INFO     |       return _bootstrap._gcd_import(name[level:], package, level)
2024-01-29T14:31:20.746003+00:00  | INFO     |   tests/test_groupby_strategies.py:10: in <module>
2024-01-29T14:31:20.747167+00:00  | INFO     |       from conda._vendor.toolz import groupby as toolz_groupby
2024-01-29T14:31:20.748327+00:00  | INFO     |   E   ModuleNotFoundError: No module named 'conda._vendor.toolz'

@jezdez is this something we should worry about? Or should we even run the tests?

@dholth
Copy link

dholth commented Jan 29, 2024

Oh, that obsolete test has been removed.

We should do the 0.3.1 release.

@jezdez
Copy link
Author

jezdez commented Jan 29, 2024

Oh, pytoolz have been dropped in conda for a bit, seems like something we can only handle by pinning an older version of conda?

It might be more practical to roll forward and do a conda-index 0.4.0 with other changes around this, including deleting that very test module.

@dholth @kenodegard Do you concur?

@jezdez
Copy link
Author

jezdez commented Jan 29, 2024

Oh, that obsolete test has been removed.

We should do the 0.3.1 release.

What's the 0.3.1 release? What we have in conda-index main right now?

@dholth
Copy link

dholth commented Jan 29, 2024

See conda/conda-index#138

@kenodegard kenodegard changed the title Switch conda-index to noarch conda-index 0.4.0 & noarch Jan 30, 2024
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_d2emq4ghcx/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:16: avoid_noarch: noarch: python packages should be avoided
    ===== Final Report: =====
    0 Errors and 1 Warning were found

Copy link

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbouss cbouss self-requested a review January 30, 2024 16:46
Copy link

@cbouss cbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add

run_constrained:
    - conda-build >=3.21.0
    - conda-package-handling >=1.9.0

Also, should the whole testing be enabled? (i.e. remove -k option from pytest)

@dholth
Copy link

dholth commented Jan 30, 2024

It doesn't use conda-package-handling or conda-build apart from the tests.

@cbouss cbouss merged commit 16fae81 into main Jan 30, 2024
8 checks passed
@cbouss cbouss deleted the noarch branch January 30, 2024 16:55
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_90t34jwqyt/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:16: avoid_noarch: noarch: python packages should be avoided
    ===== Final Report: =====
    0 Errors and 1 Warning were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants