Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entrypoint definition in pyproject.toml #5158

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Jan 30, 2024

Description

Just a small amendment for the equivalent changes to recipe/meta.yaml from
https://github.com/conda/conda-build/pull/5151/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR12 .

Checklist - did you ...

  • [ ] Add a file to the news directory (using the template) for the next release's release notes?
  • [ ] Add / update necessary tests?
  • [ ] Add / update outdated documentation?

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 30, 2024
@mbargull mbargull mentioned this pull request Jan 30, 2024
43 tasks
kenodegard
kenodegard previously approved these changes Jan 30, 2024
@mbargull mbargull marked this pull request as draft January 30, 2024 15:13
pyproject.toml Outdated
conda-build = "conda_build.cli.main_build:execute"
conda-convert = "conda_build.cli.main_convert:execute"
conda-develop = "conda_build.cli.main_develop:execute"
conda-index = "conda_build.cli.main_index:execute"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, how do we want to go about conda-index?
(The same line is also still in recipe/meta.yaml and thus needs adjusting there too.)

The cleanest way would be to

  1. add the conda-index script to the conda-index package,
  2. add a run_constrains to conda-index with conda-build>=24.1,
  3. release a new version of conda-index with those changes,
  4. add a that version as the lower bound of the conda-index dependency in conda-build.

... But IDK, if it's feasible to require a new conda-index release before the impending conda-build=24.1 release....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are already planning on a conda-index 0.4.0 release to resolve this (and a circular dependency issue for Python 3.12 support)

conda-build should no longer be making any conda-index entrypoint scripts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not possible to do a new conda-index release beforehand, we may want to set this as conda-index = "conda_index.cli.cli"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as for it still being in recipe/meta.yaml, that's a mistake we need to rectify

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are already planning on a conda-index 0.4.0 release to resolve this (and a circular dependency issue for Python 3.12 support)

conda-build should no longer be making any conda-index entrypoint scripts

Ah, wasn't aware this is already cooking :).
For reference (for future self and others):

@mbargull mbargull marked this pull request as ready for review January 30, 2024 15:32
@kenodegard kenodegard enabled auto-merge (squash) January 30, 2024 15:33
@kenodegard kenodegard merged commit 0435053 into conda:24.1.x Jan 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants