-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix entrypoint definition in pyproject.toml #5158
Fix entrypoint definition in pyproject.toml #5158
Conversation
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
pyproject.toml
Outdated
conda-build = "conda_build.cli.main_build:execute" | ||
conda-convert = "conda_build.cli.main_convert:execute" | ||
conda-develop = "conda_build.cli.main_develop:execute" | ||
conda-index = "conda_build.cli.main_index:execute" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, how do we want to go about conda-index
?
(The same line is also still in recipe/meta.yaml
and thus needs adjusting there too.)
The cleanest way would be to
- add the
conda-index
script to theconda-index
package, - add a
run_constrains
toconda-index
withconda-build>=24.1
, - release a new version of
conda-index
with those changes, - add a that version as the lower bound of the
conda-index
dependency inconda-build
.
... But IDK, if it's feasible to require a new conda-index
release before the impending conda-build=24.1
release....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are already planning on a conda-index 0.4.0
release to resolve this (and a circular dependency issue for Python 3.12 support)
conda-build
should no longer be making any conda-index
entrypoint scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not possible to do a new conda-index
release beforehand, we may want to set this as conda-index = "conda_index.cli.cli"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as for it still being in recipe/meta.yaml
, that's a mistake we need to rectify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are already planning on a
conda-index 0.4.0
release to resolve this (and a circular dependency issue for Python 3.12 support)
conda-build
should no longer be making anyconda-index
entrypoint scripts
Ah, wasn't aware this is already cooking :).
For reference (for future self and others):
Description
Just a small amendment for the equivalent changes to
recipe/meta.yaml
fromhttps://github.com/conda/conda-build/pull/5151/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR12 .
Checklist - did you ...
[ ] Add a file to thenews
directory (using the template) for the next release's release notes?[ ] Add / update necessary tests?[ ] Add / update outdated documentation?