Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-select CSS to #pass #21

Merged
merged 2 commits into from
Oct 2, 2021
Merged

Add user-select CSS to #pass #21

merged 2 commits into from
Oct 2, 2021

Conversation

thomasbnt
Copy link
Contributor

I just simply added user-select: all for select all password without double click

@AnalogCyan AnalogCyan added enhancement New feature or request hacktoberfest-accepted Approved Hacktoberfest contribution labels Oct 2, 2021
@AnalogCyan
Copy link
Owner

Thank you for your contribution! This is a useful change I hadn't thought to add.
Though, if you could please update it to include all variants of user-select as not all browsers always respect simply user-select:

  -webkit-user-select: all;
  -moz-user-select: all;
  -ms-user-select: all;
  user-select: all;

CSS-Tricks
MDN Docs

@thomasbnt
Copy link
Contributor Author

thomasbnt commented Oct 2, 2021

Though, if you could please update it to include all variants of user-select as not all browsers always respect simply user-select:

  -webkit-user-select: all;
  -moz-user-select: all;
  -ms-user-select: all;
  user-select: all;

Oh yeep 👌

@AnalogCyan AnalogCyan merged commit cdec6cb into AnalogCyan:master Oct 2, 2021
@thomasbnt
Copy link
Contributor Author

Thanks @AnalogCyan for merged this little changement.

I've got a question, how I can add Netlify checks for PR like this?
image

@AnalogCyan
Copy link
Owner

I've got a question, how I can add Netlify checks for PR like this? image

If you are deploying via Netlify as I am here, you can use the Netlify GitHub integration to automate the deploy process, run Netlify-specific checks, and automatically generate deploy previews as you see here. You can learn more on the Netlify Docs.

@thomasbnt
Copy link
Contributor Author

Thanks!

@thomasbnt thomasbnt deleted the add-user-select-to-pass-thomasbnt branch October 2, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Approved Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants