Fix create record on dnsimple #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. I'm an automated pull request bot named CapsuleCD. I handle testing, versioning and package releases for this project.
If you're interested in learning more about CapsuleCD, or adding it to your project, you can check it out here |
caius
pushed a commit
to caius/lexicon
that referenced
this pull request
Apr 4, 2019
jstaehle
added a commit
to jstaehle/certbot
that referenced
this pull request
Apr 8, 2019
In order to pick up AnalogJ/lexicon#389 which fixes a url construction issue
This was referenced Apr 8, 2019
chrisbraucker
pushed a commit
to chrisbraucker/lexicon
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the creation record on DNSimple provider, as revealed by #387.
A
/were missing to separate thev2keyword from the account id in the URL requested. Strangely, this was working before, but not anymore since a week.The missing leading
/is added in create_record to fix the behavior.