Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube New UI Problems #801

Closed
MerBudd opened this issue Nov 1, 2022 · 40 comments
Closed

YouTube New UI Problems #801

MerBudd opened this issue Nov 1, 2022 · 40 comments
Labels
bug Something isn't working

Comments

@MerBudd
Copy link

MerBudd commented Nov 1, 2022

Browser

Orion

Browser Version

0.99.120.1-beta

Extension or Userscript?

Extension

Extension/Userscript Version

3.0.0.6

Video link where you see the problem

Any video

What happened?

(About my browser, Orion is basically Apple's Safari, with support for Chrome and Firefox Extensions. I'm using the Chrome version of the extension. The issue isn't only with Orion though, I also tried with Edge and Chrome and both give the same results)

  1. "Reformat like numbers" doesn't work. Dislikes do reformat, but likes don't.

image

  1. Thumb buttons don't get recolored.

  2. The ratio bar isn't aligned with the buttons properly.

image

  1. The dislike number is positioned too close to the thumbs down button (Compare with the like number)

image

Expected Result:
The extension adapts to the new UI and doesn't have problems.

How to reproduce/recreate?

For issue 1 and 2: In the extension settings, turn on "Reformat like numbers" and choose any format. Toggle "Colorize thumbs" on as well.
Issue 3 and 4 don't require any configuration to be made to the settings.

Step 1) Go to any YouTube Video

Step 2) The issues should be visible.

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

@MerBudd MerBudd added the bug Something isn't working label Nov 1, 2022
@Moondarker
Copy link
Contributor

Moondarker commented Nov 1, 2022

  1. "Reformat like numbers" doesn't work. Dislikes do reformat, but likes don't.
  2. Thumb buttons don't get recolored.
  3. The ratio bar isn't aligned with the buttons properly.
  4. The dislike number is positioned too close to the thumbs down button (Compare with the like number)

1, 3 and 4 appear to be duplicates of #772, #733 and #776 respectively after a quick search
2 seems valid tho :)

@ryleu
Copy link

ryleu commented Nov 1, 2022

image
looks like this for me

@ryleu
Copy link

ryleu commented Nov 1, 2022

image
this is on a video from a larger channel with an older video

@Producdevity
Copy link

What does "Thumb buttons don't get recolored." mean?

@MerBudd
Copy link
Author

MerBudd commented Nov 2, 2022

What does "Thumb buttons don't get recolored." mean?

The thumb buttons are these (👍 👎)
And there's a setting to recolor them (make 👍 be green and 👎 be red) but that setting doesn't work with the new UI

@sophienix
Copy link

sophienix commented Nov 2, 2022

im having the same issue its cause youtube changed the gui load out so the elements are different most likely edit: i used ublock for this i did block element and the like buttons have a diff element now its ##.yt-spec-button-shape-next--segmented-end.yt-spec-button-shape-next--icon-button.yt-spec-button-shape-next--size-m.yt-spec-button-shape-next--mono.yt-spec-button-shape-next--tonal.yt-spec-button-shape-next > .yt-spec-button-shape-next__icon > yt-icon for the down button and for the up its ##.lottie-component > svg if you wanted to block there elements

@DemitrixQ
Copy link

изображение
When you switch on the extension of the disliking display

@Almashina
Copy link

Подтверждаю, на мозилле при использовании расширения съезжает разметка - после обновления дизайна ютубом.
2022-11-05_134147

@nsde
Copy link

nsde commented Nov 9, 2022

image

@Chrysanthemum536
Copy link

it is not showing for me.
image

@ErykDarnowski
Copy link
Contributor

ErykDarnowski commented Nov 14, 2022

Hey, I've worked on a similar issue regarding the bar misalignment (in this PR)!
Let me know if the issue still persists.

@ErykDarnowski
Copy link
Contributor

ErykDarnowski commented Nov 15, 2022

Hey, there's a proposed solution for the dislike button's text margin issue by @Ansh4011 -> here!

@ronny941
Copy link

with this new update v3.0.0.7 the extension doesn't work it's not showing the dislikes and the likes are bugged
it appears "disabled by the owner" instead of the number of likes in all the videos
please fix it

@ErykDarnowski
Copy link
Contributor

@ronny941 would you mind sharing URLs of the videos you're having issues with?

In my usage I only saw the "disabled by the owner" message a couple times!

@ronny941
Copy link

ronny941 commented Nov 22, 2022

the issue is caused by the extension because it doesn't work
it appeared this and it doesn't recognize the number of likes or dislikes in any video you watch
#801 (comment)

it never show the number of dislike and the number of like it show this
"disabled by the owner" and nothing"
if you disable the extension the number of likes of all the videos it appears again

@ErykDarnowski
Copy link
Contributor

Hey @ronny941 I've tested this on the Chrome Web Store version of the extension (3.0.0.7) on Brave (1.45.127 Chromium: 107.0.5304.110) and Windows (10 Pro - 1909) and I can't replicate this issue.

Please specify what software you're running and give examples of videos on which the issue is present.

@ronny941
Copy link

ronny941 commented Nov 23, 2022

Mozilla Firefox v107.0 64 Bit
OS: Windows 10 Pro 22H2 64 Bit
Extension: v3.0.0.7
Video link where you see the problem
All the videos

Cattura

the bug is never fixed on firefox
on chrome brave and edge it works but for firefox no
the same thing the user script is updated to v3.1.0 but with no results on firefox
the issue persist

@ronny941
Copy link

ronny941 commented Nov 23, 2022

it say "disabled by owner" and the dislikes is not showing
or 0 like and the dislikes it not showing
when i disabled the extension the likes of all videos it showed correctly
i have the latest updated version of the extension

@ronny941
Copy link

Hey @ronny941 I've tested this on the Chrome Web Store version of the extension (3.0.0.7) on Brave (1.45.127 Chromium: 107.0.5304.110) and Windows (10 Pro - 1909) and I can't replicate this issue.

Please specify what software you're running and give examples of videos on which the issue is present.

the problem is only on firefox v107.0
as you can see it the extension doesn't work
on chrome edge and brave it works but on firefox with the update v3.0.0.7 and the script v3.1.0 is not working

@ErykDarnowski
Copy link
Contributor

@ronny941 I've tested this on Firefox (107.0) with the extension from the Firefox ADD-ONS store (v3.0.0.7). I even tried switching my system's language to italian but I still couldn't replicate the problem.

Could you try replicating this issue on another computer?

@ronny941
Copy link

@ronny941 I've tested this on Firefox (107.0) with the extension from the Firefox ADD-ONS store (v3.0.0.7). I even tried switching my system's language to italian but I still couldn't replicate the problem.

Could you try replicating this issue on another computer?

i don't have any another pc for verify this issue
but i don't understand why doesn't work

@ErykDarnowski
Copy link
Contributor

Well me neither. If I can't replicate the issue I can't fix it.

@ronny941
Copy link

Well me neither. If I can't replicate the issue I can't fix it.

in every video it gives me this
https://user-images.githubusercontent.com/38260267/198912946-02db207e-756f-46d3-9ae6-87042d5f13a2.png
i installed the extension updated but the problem it remains
i disabled the extension and enabled but it doesn't work
i try removed and reinstalled but it doesnt' work
i try the script with violentmonkey but it doesn't work

@ronny941
Copy link

Cattura
in every video it gives me this
i installed the extension updated but the problem it remains
i disabled the extension and enabled but it doesn't work
i try removed and reinstalled but it doesnt' work
i try the script with violentmonkey but it doesn't work

@ronny941
Copy link

it's the extension savefrom the problem
i have disabled and it worked
i hope they do a fix

@ErykDarnowski
Copy link
Contributor

The only thing I can suggest at this point is either trying to replicate this on a different computer or if that's not possible, doing so in a virtual machine.

Like I said. If I can't replicate the issue, I can't fix it.

@ronny941
Copy link

ronny941 commented Nov 24, 2022

The only thing I can suggest at this point is either trying to replicate this on a different computer or if that's not possible, doing so in a virtual machine.

Like I said. If I can't replicate the issue, I can't fix it.

the problem is the extension savefrom net helper
on the chromium browser this extension don't work on youtube because the download for youtube is disabled
i have disabled and now the extension is working fine
i hope they updated the savefrom net extension for firefox to fix the bug

@ErykDarnowski
Copy link
Contributor

ErykDarnowski commented Nov 24, 2022

Ohh, ok. My bad, I should have noticed this. I get it now.

In that case this issue is also related!

I'll test this out now.

@ronny941
Copy link

Ohh, ok. My bad, I understand now. In that case this issue is also related!

I'll test this out now.

thank you for your work and your disponibility

@ErykDarnowski
Copy link
Contributor

ErykDarnowski commented Nov 24, 2022

I mean, It's you that figured it out in the end, so congrats! 😄


I've managed to replicate the issue on my end:

image

I'm also happy to say that the fix I proposed here does resolve the issue but it also messes up the order of the buttons.

before:

image

after:

image


This fix clearly needs a bit more work and testing, but it's a good start!

@ronny941
Copy link

ok i wait the fix for now i disabled savefrom net extension

@ErykDarnowski
Copy link
Contributor

  1. "Reformat like numbers" doesn't work. Dislikes do reformat, but likes don't.
  2. Thumb buttons don't get recolored.
  3. The ratio bar isn't aligned with the buttons properly.
  4. The dislike number is positioned too close to the thumbs down button (Compare with the like number)

1, 3 and 4 appear to be duplicates of #772, #733 and #776 respectively after a quick search 2 seems valid tho :)

After going over the whole issue and also noticing this ^ comment (by @Moondarker), in my opinion closing this issue and opening a new one titled "Like / dislike buttons don't get recolored" would be the best move (as that's the only distinct issue in this whole thread)!

@josiahb217
Copy link

In relation to the offset and #733 mentioned here, it is still noticeable that the ratio is offset, not centered. Even in the post that @ErykDarnowski posted, the after photo shows this. I have included my own photo with lines added for clarity. Sorry, I don't post to Github and I see this as being an old topic. Couldn't figure out if there was anything more recent or if a new issue should be started.
Offset

@ErykDarnowski
Copy link
Contributor

Hey @josiahb217, thank you for noticing that!

In the comment you're referring to, I was only talking about the issue of the bar stretching and not it's offset (I've talked about that in this and this comment + I've implemented a fix in this PR draft).

Unfortunately, the issues on this repo are really messy and often report the same problem. Which of course, causes a lot of confusion and allows for situations like this to occur!

Although my PR hasn't been merged, I see that this offset isn't present anymore (at least if you clone the repo and build the extension yourself). As of now, the "store" version of the extension, still has that offset (3.0.0.7).

@Wolterhon
Copy link

изображение
This can happen when the video's aspect ratio is close to a square's (4:3 in this case)

@ErykDarnowski
Copy link
Contributor

Hey @Wolterhon

I've also encountered this, but in my case it happened when I was watching youtube on my vertical monitor (when the browser window is quite small horizontally). I'm working on a fix for this here.

@PickleNik
Copy link
Collaborator

изображение This can happen when the video's aspect ratio is close to a square's (4:3 in this case)

this will be tracked in #924

@PickleNik
Copy link
Collaborator

the SafeForm conflict will be tracked in #769

@PickleNik
Copy link
Collaborator

  1. recoloring will be tracked in Like / dislike buttons don't get recolored #848

@PickleNik
Copy link
Collaborator

1, 3 and 4 have been fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests