Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Recursion on Some Video #846

Closed
1 task done
Dheatly23 opened this issue Dec 8, 2022 · 8 comments
Closed
1 task done

Infinite Recursion on Some Video #846

Dheatly23 opened this issue Dec 8, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@Dheatly23
Copy link

Dheatly23 commented Dec 8, 2022

Have you tried to find similar open issues?

  • Yes, this issue is not a duplicate

Browser

Mozilla Firefox

Browser Version

Firefox 107.0.1

Extension or Userscript?

Extension

Extension/Userscript Version

3.0.0.7

Video link where you see the problem

https://www.youtube.com/watch?v=K3CzPnQ9G5I

What happened?

When opening video, a massive amount of lag happened. Dislike bar flickers frequently. Really hard to scroll, click, or do anything. Only by disabling the extension the lag disappears.

How to reproduce/recreate?

  1. Open the video.
  2. Open console.
  3. Wait until recursion errors (may take a minute).

Example screenshot:
screenshot

Another example on different video:
screenshot 2

NOTE: May be caused by interaction with some other extensions (not exactly known what or why). Current combination that cause problems:

Click to expand

My combination:

  1. uBlock Origin
  2. Decentraleyes
  3. Dark Reader
  4. Breakthrough Twitter Login Wall
  5. Multithreaded Download Manager
  6. Youtube-shorts block

From discussion below:

  1. uBlock Origin
  2. Sponsorblock
  3. Youtube-shorts block
  4. Youtube Nonstop
  5. Bypass Paywalls
  6. enhanced-h264ify

From #859

  1. Zoom Page WE

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

@Dheatly23 Dheatly23 added the bug Something isn't working label Dec 8, 2022
@Anarios
Copy link
Owner

Anarios commented Dec 8, 2022

Thanks for report, so far I can't reproduce it. Must be something specific about your configuration.

@Dheatly23
Copy link
Author

Dheatly23 commented Dec 10, 2022

Thanks for the response. Here are a few more notes:

  1. I do have many extensions installed, i'll try to disable one by one.
  2. When i launch in private window (which i disallow RYD) the lag disappears.
  3. Same happens when i manually disable it.

Any suggestion on help debugging it?

EDIT: Here are a extension list:

  • uBlock Origin
  • Decentraleyes
  • Dark Reader
  • Breakthrough Twitter Login Wall
  • Multithreaded Download Manager
  • Youtube-shorts block

@Dheatly23
Copy link
Author

Found it! After quickly opening console i found this recursion error. It gets so laggy it crashed my browser. Will try to upload better quality later.

image

@Dheatly23 Dheatly23 changed the title Excessive Lag on Specific Video Infinite Recursion on Some Video Dec 11, 2022
@hallo1126
Copy link

hallo1126 commented Dec 18, 2022

I can confirm this issue, I have the exact same problem, with the exact same error message, with the problem being gone when I disable this specific addon (and the issue has been going on for about the same timeframe, it is just that today I got around to trying to fix it). I have no visual feedback on the dislike bar though, but severe input lag on doing anything on the web page, the video runs too but is also affected by the input lag (trying to pause/unpause/skip though the video).

It happens exclusively with videos of very short length, about less than 2 minutes I would guess.

I have the following addons installed:

uBlock Origin
Sponsorblock
Youtube-shorts block
Youtube Nonstop
Bypass Paywalls
enhanced-h264ify (I have a Thinkpad X220, a model too old to run modern codecs. However as I mentioned, the video itself does not lag and when sluggishly going into the provided statistics, it is still displayed as running as avc1. Also the issue still pertains when the video is paused)

As far as I can tell, disabling either individual ones of them does not work, only disabling Return Youtube Dislike stops the issue, so I am not sure there is any conflict.

@ImpenetrableNoble
Copy link

ImpenetrableNoble commented Dec 18, 2022 via email

@hallo1126
Copy link

@TheGoldenSun What is your browser addon list and hardware?

@Dheatly23
Copy link
Author

@hallo1126 @TheGoldenSun If i may ask, is it the same video i linked in the issue or are there any other example? Maybe there is some pattern here.

@Anarios
Copy link
Owner

Anarios commented Aug 27, 2024

I think this was similar to #1074 and should be fixed by the same fix

@Anarios Anarios closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@Anarios @hallo1126 @Dheatly23 @ImpenetrableNoble and others