Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: turn tech to modifier #32

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Conversation

trym-b
Copy link
Collaborator

@trym-b trym-b commented Mar 23, 2024

Best reviewed commit by commit

This commit solves the following error:

```
[techtreepanel.cpp:161]: Trying to add a tech
(horde_mod) to a category that does not exist in
the UI
```

This tech is now replaced by a few modifiers.
This commit solves the following error:

```
[techtreepanel.cpp:161]: Trying to add a tech
(italian_republic_mod) to a category that does not
exist in the UI
```

This tech is now replaced by a few modifiers.
This commit solves the following error:

```
[techtreepanel.cpp:161]: Trying to add a tech
(merchant_republic_mod2) to a category that does
not exist in the UI
```

This tech is now replaced by a modifier.
This commit solves the following error:

```
[techtreepanel.cpp:161]: Trying to add a tech
(merchant_republic_mod) to a category that does
not exist in the UI
```

This tech is now replaced by a modifier.
This commit solves the following error:

```
[techtreepanel.cpp:161]: Trying to add a tech
(silk_road) to a category that does not exist in
the UI
```

This tech is now replaced by a modifier.
This commit solves the following error:

```
[techtreepanel.cpp:161]: Trying to add a tech
(defensive_tech_mod) to a category that does not
exist in the UI
```

This tech is now replaced by a modifier.
This commit solves the following error:

```
[techtreepanel.cpp:161]: Trying to add a tech
(elysium) to a category that does not exist in the
UI
```

This tech is now replaced by a modifier.

Also removed the technology from `AOS` since it
does not even have `elysian` as a primary culture.
@AndHope AndHope merged commit 0aecbdf into main Mar 24, 2024
1 check passed
@AndHope AndHope deleted the refactor/turn-tech-to-modifier branch March 24, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants