Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render trait display names everywhere #472

Merged
merged 33 commits into from
Apr 18, 2024
Merged

Render trait display names everywhere #472

merged 33 commits into from
Apr 18, 2024

Commits on Feb 9, 2024

  1. Add launch config for POPULATE_PHENOTYPES_DATABASE

    @vlagrassa
    vlagrassa committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    776892d View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge branch 'development' into enhancement/phenotype-datastore-multi… 

    …ple-name-fields
    @vlagrassa
    vlagrassa committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8a057e7 View commit details
    Browse the repository at this point in the history

  2. Add trait display names to Google Sheet > GCP db op

    @vlagrassa
    vlagrassa committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    527b169 View commit details
    Browse the repository at this point in the history

  3. Add trait display names to datastore entity class

    @vlagrassa
    vlagrassa committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    eec1ba4 View commit details
    Browse the repository at this point in the history

  4. Better fallback behavior for display name

    @vlagrassa
    vlagrassa committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8e01dd2 View commit details
    Browse the repository at this point in the history

  5. Display tags column as flex-row 

    Fixes rendering error if tags list is shorter than other columns (height-wise)
    @vlagrassa
    vlagrassa committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a31c172 View commit details
    Browse the repository at this point in the history

  6. Render empty table cell if no short description

    @vlagrassa
    vlagrassa committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0cfa693 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Remove unused "label" field from trait report & link with "View Repor… 

    …t" col
    @vlagrassa
    vlagrassa committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9918388 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'fix/trait-name-styling' into enhancement/phenotype-data… 

    …store-multiple-name-fields
    @vlagrassa
    vlagrassa committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7e8f463 View commit details
    Browse the repository at this point in the history

  2. Move trait multiline HTML to new utils file

    @vlagrassa
    vlagrassa committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1b258b8 View commit details
    Browse the repository at this point in the history

  3. Render trait display name in reports page w new macro

    @vlagrassa
    vlagrassa committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    efec6a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Move trait JSON query to util function

    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    cd5736e View commit details
    Browse the repository at this point in the history

  2. When selecting trait, query info from database directly 

    Replaces ad-hoc object construction with a structured query.  This is the same query we run to fill out the offcanvas sidebar.

Removes `data-description` and `data-species` fields from table rows, since we're now looking this information up in the database directly.
    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3d21dac View commit details
    Browse the repository at this point in the history

  3. Render trait display name in trait selectors

    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5f5c8e7 View commit details
    Browse the repository at this point in the history

  4. Remove repeat listings for display name fields

    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ff72030 View commit details
    Browse the repository at this point in the history

  5. Reorganize TraitFile props a bit

    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c356254 View commit details
    Browse the repository at this point in the history

  6. Render trait display names in graph axes

    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7726bb9 View commit details
    Browse the repository at this point in the history

  7. Move report list individual tool cols to Jinja 

    Store as Jinja dict linked to tool bp name. Rendered with macros.
    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    efe677b View commit details
    Browse the repository at this point in the history

  8. Cache trait display names in report objects 

    Adds new class method for `PhenotypeReport` to recompute all cached names.
    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    38127cd View commit details
    Browse the repository at this point in the history

  9. Render trait display names in reports list w custom renderer

    @vlagrassa
    vlagrassa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    84bcdf2 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Fix initial trait none check (again)

    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    881298d View commit details
    Browse the repository at this point in the history

  2. Sort out PhenotypeReport trait name fields (see desc) 

    - Replace `trait_{n}_name` with `trait_{n}_name_caendr`
- Compute display name(s) when creating new report & in the recompute function
- Now use `trait_{n}_name_display` directly to render report page
    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5cb6222 View commit details
    Browse the repository at this point in the history

  3. Render report axis labels with styling (bold, italics, etc)

    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7c3de83 View commit details
    Browse the repository at this point in the history

  4. Add DbOp for recomputing cached phenotype report display names

    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    42741be View commit details
    Browse the repository at this point in the history

  5. Set full CaeNDR trait name as display name for Zhang traits

    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    958bd5a View commit details
    Browse the repository at this point in the history

  6. Use trait display names in offcanvas header

    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a547a41 View commit details
    Browse the repository at this point in the history

  7. Fix: render axis labels as HTML in single-trait report

    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    230c61f View commit details
    Browse the repository at this point in the history

  8. Fix: move display name computation to Trait & use to initialize Zhang… 

    … trait in selector properly
    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    db868e2 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'development' into enhancement/phenotype-datastore-multi… 

    …ple-name-fields
    @vlagrassa
    vlagrassa committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8d09fda View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'development' into enhancement/phenotype-datastore-multi… 

    …ple-name-fields
    @vlagrassa
    vlagrassa committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    997252e View commit details
    Browse the repository at this point in the history

  2. Check Google Sheet columns before parsing rows

    @vlagrassa
    vlagrassa committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    011de8d View commit details
    Browse the repository at this point in the history

  3. Fix: trait lookup request data

    @vlagrassa
    vlagrassa committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    db31f33 View commit details
    Browse the repository at this point in the history

  4. Flash error message if trait metadata request fails

    @vlagrassa
    vlagrassa committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    75e9873 View commit details
    Browse the repository at this point in the history