Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure CMakeLists.txt to install files in a ROS compatible way. #34

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

malban
Copy link
Contributor

@malban malban commented Jul 5, 2022

Configure CMakeLists.txt to install files in a ROS compatible way. This updates the csm_eigen branch to bring it into line with the main branch in terms of installing package information and build artifacts so they can be found and referenced by downstream ROS packages.

References: #33

Copy link
Collaborator

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested by myself but this looks reasonable.

Because I'm not sure how csm_eigen branch should be handled, I'm not sure either how much merging this PR into that branch makes sense? Recent changes don't seem to be merged into it. That said, I'll leave that up to other maintainers. Readme reads as following and it sounds like an experiment for a project back then. If the changes in csm_eigen should be ported to the main branch, someone has to do it.

There is also another branch, called csm_eigen, which uses the eigen library. This branch is the work of people working at U. Freiburg and Kuka, including Christoph Sprunk and Rainer Kuemmerle.

package.xml Show resolved Hide resolved
@130s 130s mentioned this pull request Jul 5, 2022
@130s
Copy link
Collaborator

130s commented Jul 15, 2022

FYI I asked about the plan regarding the branching onward in #33 (comment).

CMakeLists.txt Show resolved Hide resolved
@130s 130s merged commit 04c4a31 into AndreaCensi:csm_eigen Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants