Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: make all configuration options available with cli flags #20

Closed
1 task done
AndreasAugustin opened this issue Aug 17, 2023 · 0 comments · Fixed by #22
Closed
1 task done

[Feat]: make all configuration options available with cli flags #20

AndreasAugustin opened this issue Aug 17, 2023 · 0 comments · Fixed by #22
Assignees
@AndreasAugustin
Labels
enhancement New feature or request

Comments

@AndreasAugustin
Copy link
Owner

Describe the feature

Currently you are able to configure the cli with a config file or environment variables.
normally one would expect to be able to configure the cli also with cli flags.

A map betweeen the cli options and configuration options would be nice to have.

Use Case

sometimes one like to use configuration options with cli flags, e.g. within CI tasks or when you want to try something out or you have an exceptional case.

Proposed Solution

use the viper pflag mapping https://gist.github.com/brianclements/841ea7bffdb01346392c

Acknowledgements

  • I may be able to implement this feature request
@AndreasAugustin AndreasAugustin added the enhancement New feature or request label Aug 17, 2023
AndreasAugustin added a commit that referenced this issue Aug 17, 2023
@AndreasAugustin
feat: ✨ (#20) bind viper flags with cobra flags
b41bbc0
@AndreasAugustin AndreasAugustin mentioned this issue Aug 17, 2023
Merged
AndreasAugustin added a commit that referenced this issue Aug 17, 2023
@AndreasAugustin
feat: ✨ (#20) bind viper flags with cobra flags
efa92ef
@AndreasAugustin AndreasAugustin self-assigned this Aug 17, 2023
AndreasAugustin added a commit that referenced this issue Aug 17, 2023
@AndreasAugustin
feat: ✨ (#20) bind viper flags with cobra flags (#22)
dbb37a0 
* feat: ✨ (#20) bind viper flags with cobra flags

* feat: ✨ (#20) bind viper flags with cobra flags
@AndreasAugustin AndreasAugustin mentioned this issue Aug 17, 2023
Closed
1 task
AndreasAugustin added a commit that referenced this issue Aug 17, 2023
@AndreasAugustin
Feat/contain m flags (#24)
1179648 
* feat: ✨ (#20) bind viper flags with cobra flags

* feat: ✨ (#20) bind viper flags with cobra flags

* feat: ✨ (#21) preparations to parse the messages

* feat: ✨ (#21) commit implemented

* feat: ✨ (#21) commit implemented

* docs: 🗑️ issues are now tracked within github issues

* feat: 🚀 add debug to config

* foo

* foo

* foo

* foo

bar

* foo

bar

* foo

* foo

* fix: 🐛 fix issue on windows
@github-actions github-actions bot mentioned this issue Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasAugustin AndreasAugustin

Labels
enhancement New feature or request
Projects
go-gitmoji-cli
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ✨ (#20) bind viper flags with cobra flags AndreasAugustin/go-gitmoji-cli
1 participant
@AndreasAugustin