Switch to Typescript #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Oh wow, thanks for the contribution. This is a lot of work. It may take me a bit to review this but I'm absolutely open to making the switch to TS |
|
Great, nice to hear. Looking forward to your feedback. |
Andrew-Dickinson
requested changes
Aug 5, 2023
No, it should not cause any issues. But you don't have typing for the |
|
Any news on this? Waiting for me? |
|
Apologies. I caught COVID. I will try to take a look this weekend
…On Mon, Aug 14, 2023, 12:12 Ruedi Steinmann ***@***.***> wrote:
Any news on this? Waiting for me?
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAX6K6O57GNRZY264GQDHJDXVJFALANCNFSM6AAAAAA24VPEP4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Andrew-Dickinson
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Anycubic Photon had a hard time with the generated .pws file, so I wanted to add support for .photon. I had a hard time understanding the code and thought some types would greatly help.
I also dropped the checked in libraries and switched to npm packages.
Oh, and I also changed the anti-alias count from 0 to 1. UVTools had a division by zero before...
What do you think?