Skip to content

Commit

Permalink
obtain comment publishedAt date #24
Browse files Browse the repository at this point in the history
  • Loading branch information
yshrsmz committed Apr 24, 2018
1 parent d9e1fea commit 2f1940a
Show file tree
Hide file tree
Showing 14 changed files with 46 additions and 0 deletions.
1 change: 1 addition & 0 deletions apollo/queries/getMilestoneByNumber.gql
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ query getMilestoneByNumber(
}
nodes {
body
publishedAt
author {
login
url
Expand Down
1 change: 1 addition & 0 deletions apollo/queries/getMilestones.gql
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ query getMilestones(
}
nodes {
body
publishedAt
author {
login
url
Expand Down
3 changes: 3 additions & 0 deletions static/api/issue/1-20180128-20180203.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
"nodes": [
{
"body": "システム側の開発が記事になることって珍しい気がする",
"publishedAt": "2018-03-23T04:31:16Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -142,6 +143,7 @@
"nodes": [
{
"body": "ドキュメントから見れるらしい",
"publishedAt": "2018-03-23T04:29:10Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -180,6 +182,7 @@
"nodes": [
{
"body": "ViewSliceというLifecycleObseverとKotlinのAndroid extensionsを利用したViewを小さなパーツに分けて実装していく仕組みがおもしろい",
"publishedAt": "2018-03-23T04:25:48Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
3 changes: 3 additions & 0 deletions static/api/issue/10-20180401-20180407.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"nodes": [
{
"body": "takahiromさんが解説記事を Medium に投稿しています\r\nhttps://medium.com/@takahirom/introduce-hyperion-android-2738c2f3a350",
"publishedAt": "2018-04-08T09:16:26Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -209,6 +210,7 @@
"nodes": [
{
"body": "これは捗りそう…",
"publishedAt": "2018-04-10T15:04:13Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -242,6 +244,7 @@
"nodes": [
{
"body": "本題とずれるのですが、元はエミュレータが動かない、という問題らしくて、ちょっと同情しました",
"publishedAt": "2018-04-08T09:14:11Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down
4 changes: 4 additions & 0 deletions static/api/issue/12-20180415-20180421.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"nodes": [
{
"body": "ここでゴニョゴニョつぶやいてますが、まだAPIはバギーなのでAndroid P Preview 2に期待したいところっすね!\r\nhttps://twitter.com/operandoOS/status/987566097653088256",
"publishedAt": "2018-04-22T11:38:43Z",
"author": {
"login": "operando",
"url": "https://github.com/operando",
Expand All @@ -40,6 +41,7 @@
},
{
"body": "なるほど!DP2でまた変わりそうな気もしますね。ところで、この機能に気付いたのは岡野さんのツイートが発端でした。いつもありがとうございます!",
"publishedAt": "2018-04-23T00:41:11Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -271,6 +273,7 @@
"nodes": [
{
"body": "<blockquote class=\"twitter-tweet\" data-lang=\"ja\"><p lang=\"en\" dir=\"ltr\">Lint in AGP 3.2 alpha 11 adds a &#39;SyntheticAccessor&#39; check which you can enable to eradicate these useless methods from your libraries. Learn more about them here: <a href=\"https://t.co/xCE4J6rAdv\">https://t.co/xCE4J6rAdv</a>. Also re-computed updated synthetic accessor method counts (slide 77) from apps on my phone. <a href=\"https://t.co/88SPzJwpNC\">pic.twitter.com/88SPzJwpNC</a></p>&mdash; Jake Wharton (@JakeWharton) <a href=\"https://twitter.com/JakeWharton/status/985930270074425345?ref_src=twsrc%5Etfw\">2018年4月16日</a></blockquote>\r\n",
"publishedAt": "2018-04-17T02:07:55Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand All @@ -279,6 +282,7 @@
},
{
"body": "アプリ起動時のメソッドトレース、いいですね。欲しかった機能の1つです。",
"publishedAt": "2018-04-18T00:45:20Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down
3 changes: 3 additions & 0 deletions static/api/issue/2-20180204-20180210.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"nodes": [
{
"body": "Android Studio 3.1 Beta2も出た模様(リリースノート付き)\r\nhttps://androidstudio.googleblog.com/2018/02/android-studio-31-beta-2-is-now.html",
"publishedAt": "2018-03-23T04:59:06Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -370,6 +371,7 @@
"nodes": [
{
"body": "Android KTXへのPRに対するJakeのコメントから判明",
"publishedAt": "2018-03-23T04:39:24Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand All @@ -378,6 +380,7 @@
},
{
"body": "Architecture ComponentsのLifecycleが追加されたこともandroid.app.Fragment​が非推奨になる一因かもしれない",
"publishedAt": "2018-03-23T04:39:29Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
15 changes: 15 additions & 0 deletions static/api/issue/3-20180211-20180217.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"nodes": [
{
"body": "guavaのOptionalとjava.util.Optionalをサポートしたらしいけど、どちらも使うにはハードルが高い​🤔​",
"publishedAt": "2018-03-23T07:11:36Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -101,6 +102,7 @@
"nodes": [
{
"body": "​​DroidKaigiの発表ですが、身に詰まされるものがあります",
"publishedAt": "2018-03-23T06:27:31Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -128,6 +130,7 @@
"nodes": [
{
"body": "古い記事ですが、ちょうどタイムゾーンの話題がさいきんあったので面白かったです\r\n",
"publishedAt": "2018-03-23T06:27:18Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -155,6 +158,7 @@
"nodes": [
{
"body": "​​考えることが増えそう",
"publishedAt": "2018-03-23T07:11:12Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -188,6 +192,7 @@
"nodes": [
{
"body": "マイグレーションのテストを書くサポートがあるの、よさそう",
"publishedAt": "2018-03-23T06:27:07Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -221,6 +226,7 @@
"nodes": [
{
"body": "これ、たぶん、Retrofit側にも手を入れないとできないと思う",
"publishedAt": "2018-03-23T06:26:49Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand All @@ -229,6 +235,7 @@
},
{
"body": "https://twitter.com/JakeWharton/status/964556938322341894\r\n​​こういうツイートもしていたので今後が気になりますね",
"publishedAt": "2018-03-23T07:10:53Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -286,6 +293,7 @@
"nodes": [
{
"body": "data classにしとくとassertionが楽でいいですよね",
"publishedAt": "2018-03-23T07:10:32Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -319,6 +327,7 @@
"nodes": [
{
"body": "アプリによってはMITM攻撃を防ぐために必要になるピン留めとそのリスクについて。reddit内で言及されているこの記事も参考になります。https://commonsware.com/blog/2016/11/28/certificate-pinning-failing-open.html",
"publishedAt": "2018-03-23T06:26:32Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -352,6 +361,7 @@
"nodes": [
{
"body": "​​同じgradleでマルチプラットフォーム向けにビルドできるようになったらしい",
"publishedAt": "2018-03-23T06:26:20Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand All @@ -360,6 +370,7 @@
},
{
"body": "​​組み込み機器向けに書けるようになったのも気になります",
"publishedAt": "2018-03-23T07:10:11Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -398,6 +409,7 @@
"nodes": [
{
"body": "​​konifarさんのDroidKaigiでの話とそんなに変わらないですが、Reddit民の反応が気になります",
"publishedAt": "2018-03-23T06:26:02Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -431,6 +443,7 @@
"nodes": [
{
"body": "どこかで聞いた話だ ​​:pensive:",
"publishedAt": "2018-03-23T06:25:44Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand Down Expand Up @@ -464,6 +477,7 @@
"nodes": [
{
"body": "buildSrcモジュールを用意し、そこではKotlinでdependency記述用のobjectを作成する。ext使う方法とは違い、こちらだとコード補完機能も動く",
"publishedAt": "2018-03-23T06:18:39Z",
"author": {
"login": "hkurokawa",
"url": "https://github.com/hkurokawa",
Expand All @@ -472,6 +486,7 @@
},
{
"body": "​​Androidのsupportライブラリもこの方法に移行したとか",
"publishedAt": "2018-03-23T07:12:05Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
4 changes: 4 additions & 0 deletions static/api/issue/4-20180218-20180224.json
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@
"nodes": [
{
"body": "私はPublishSubject使うことが多いですねー。で、View側でそのままsubscribeするか、あるいは毎回LiveDataに変換する",
"publishedAt": "2018-03-23T09:19:26Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -263,6 +264,7 @@
"nodes": [
{
"body": "コア開発者の一人がApplicationクラスはそもそも存在するべきではなかった、と後悔しているという話はちょっと驚きだった",
"publishedAt": "2018-03-23T09:16:40Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -349,6 +351,7 @@
"nodes": [
{
"body": "Flutter、だいぶ話題に上がるようになってきた印象",
"publishedAt": "2018-03-23T09:15:01Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -382,6 +385,7 @@
"nodes": [
{
"body": "​​コメントで参照されているリンクもかなり有益",
"publishedAt": "2018-03-23T09:13:50Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
1 change: 1 addition & 0 deletions static/api/issue/5-20180225-20180303.json
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@
"nodes": [
{
"body": "​​requireContextとかrequireActivityとか、Nullableアノテーションに対するアンサー的メソッドが追加されている",
"publishedAt": "2018-03-24T13:13:48Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
2 changes: 2 additions & 0 deletions static/api/issue/6-20180304-20180310.json
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@
"nodes": [
{
"body": "applyは非同期だから、apply直後にアプリがクラッシュしたりすると値が保存されないっていう挙動に以前ハマったことがあります",
"publishedAt": "2018-03-24T13:29:33Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -227,6 +228,7 @@
"nodes": [
{
"body": "実装的にはこんな感じ。\r\n面白いですね https://github.com/android/android-ktx/blob/b83f4a6e7fd98115b497fbd3bc9f450c49f6abcf/src/main/java/androidx/graphics/Color.kt",
"publishedAt": "2018-03-24T13:25:17Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
3 changes: 3 additions & 0 deletions static/api/issue/7-20180311-20180317.json
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
"nodes": [
{
"body": "今作ってるサービスは似たようなコンセプトで作ってます",
"publishedAt": "2018-03-27T11:00:38Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -209,6 +210,7 @@
"nodes": [
{
"body": "​​I/Oでセッションがありそうですね!\r\n​​https://events.google.com/io/schedule/?section=day&sid=f01ba5cd-7dc7-4028-a1c5-55140ea62bb1&topic=android%26play",
"publishedAt": "2018-03-27T08:52:05Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -242,6 +244,7 @@
"nodes": [
{
"body": "​​“Android”とは言っているけど、特にAndroidエンジニアに限った話でもないかもしれない",
"publishedAt": "2018-03-27T08:50:01Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
2 changes: 2 additions & 0 deletions static/api/issue/8-20180318-20180324.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@
"nodes": [
{
"body": "好きな言語の2位がKotlin",
"publishedAt": "2018-04-04T09:12:11Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -293,6 +294,7 @@
"nodes": [
{
"body": "​​やっぱりこの手のレビューは世界共通なんですね",
"publishedAt": "2018-04-04T09:09:39Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
3 changes: 3 additions & 0 deletions static/api/issue/9-20180325-20180331.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@
"nodes": [
{
"body": "​​thagikuraさんのツイートとそのリプライツリーも興味深いです https://twitter.com/thagikura/status/978072117206908928",
"publishedAt": "2018-04-04T09:20:32Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -190,6 +191,7 @@
"nodes": [
{
"body": "これ思い出しました\r\n https://twitter.com/johnregehr/status/920691341738123264",
"publishedAt": "2018-04-04T09:18:27Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down Expand Up @@ -271,6 +273,7 @@
"nodes": [
{
"body": "😇 \r\nhttps://www.reddit.com/r/androiddev/comments/86n6fw/how_can_8_years_old_dead_application_still_be_on/dw79mna/",
"publishedAt": "2018-04-04T09:15:51Z",
"author": {
"login": "yshrsmz",
"url": "https://github.com/yshrsmz",
Expand Down
1 change: 1 addition & 0 deletions types/GitHubApi.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export type GHAuthor = {

export type GHComment = {
body: string;
publishedAt: string;
author: GHAuthor;
};

Expand Down

0 comments on commit 2f1940a

Please sign in to comment.