feat(GuildQueuePlayerNode): implement demuxer #1827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements demuxer for
webm/opus
andogg/opus
streams. When such streams are available and condition does not require the use of ffmpeg, discord-player will skip ffmpeg entirely. This update does not include breaking changes. Developers currently have to passskipFFmpeg: true
in main player options for this to work. We may enable this by default after performing enough tests (in production).You can still use filters such as
volume controller
,equalizer
orbiquad
while usingskipFFmpeg
without any issues. You can also use ffmpeg filters but discord-player will switch back to ffmpeg when you use ffmpeg filters or seek().skipFFmpeg
may not work all the time, but you should not notice any differences as a user. Currently, this only works withYoutubeExtractor
(while usingyoutube-ext
,ytdl-core
and@distube/ytdl-core
-play-dl
users can try and give feedbacks if needed,yt-stream
is not implemented yet).Status