Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildQueuePlayerNode): implement demuxer #1827

Merged
merged 1 commit into from
Oct 14, 2023
Merged

feat(GuildQueuePlayerNode): implement demuxer #1827

merged 1 commit into from
Oct 14, 2023

Conversation

twlite
Copy link
Collaborator

@twlite twlite commented Oct 14, 2023

Changes

This PR implements demuxer for webm/opus and ogg/opus streams. When such streams are available and condition does not require the use of ffmpeg, discord-player will skip ffmpeg entirely. This update does not include breaking changes. Developers currently have to pass skipFFmpeg: true in main player options for this to work. We may enable this by default after performing enough tests (in production).

You can still use filters such as volume controller, equalizer or biquad while using skipFFmpeg without any issues. You can also use ffmpeg filters but discord-player will switch back to ffmpeg when you use ffmpeg filters or seek().

skipFFmpeg may not work all the time, but you should not notice any differences as a user. Currently, this only works with YoutubeExtractor (while using youtube-ext, ytdl-core and @distube/ytdl-core - play-dl users can try and give feedbacks if needed, yt-stream is not implemented yet).

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
discord-player-website ✅ Ready (Inspect) Visit Preview Oct 14, 2023 5:38am

@twlite
Copy link
Collaborator Author

twlite commented Oct 14, 2023

This feature is available in dev channel: npm install discord-player@dev @discord-player/extractor@dev

@twlite twlite merged commit 5b7c71c into master Oct 14, 2023
4 checks passed
@twlite twlite deleted the demuxer-setup branch October 14, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant