Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ExtractorExecutionContext): allow passing options via loadDefault #1847

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat(ExtractorExecutionContext): allow passing options via loadDefault #1847

merged 5 commits into from
Oct 23, 2023

Conversation

twlite
Copy link
Collaborator

@twlite twlite commented Oct 23, 2023

Changes

This PR adds options parameter to loadDefault method of ExtractorExecutionContext which allows devs to pass extractor options in this format:

await player.extractors.loadDefault(null, {
  ExtractorName: {...}
});

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@twlite twlite added area:main Related to discord-player area:extractor Extractors related labels Oct 23, 2023
@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-player-website ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 6:11pm

@twlite twlite merged commit 2aaa715 into master Oct 23, 2023
4 checks passed
@twlite twlite deleted the extractor-loaddefault-options branch October 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:extractor Extractors related area:main Related to discord-player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@twlite