Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove unnecessary bridgeProvider check #1859

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Rizina
Copy link
Contributor

@Rizina Rizina commented Oct 30, 2023

Changes

Remove unnecessary ternary check for bridgeProvider in AppleMusicExtractor and SpotifyExtractor.

This check is not necessary because the baseExtractor already returns default bridgeProvider in case user hasn't provided any.

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-player-website ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 4:51pm

Copy link
Collaborator

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@twlite twlite merged commit 2704182 into Androz2091:master Oct 30, 2023
2 of 3 checks passed
@twlite twlite added semver:patch area:extractor Extractors related labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants